Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'No matches found' tooltip persists even after inputting item in combobox #2589

Open
sktguha opened this issue Aug 17, 2020 · 9 comments
Open
Labels

Comments

@sktguha
Copy link

sktguha commented Aug 17, 2020

In combobox, the 'no matches found' tooltip is not cleared after the user has inputted the input after pressing enter.

Steps to reproduce:

Go to https://react.lightningdesignsystem.com/components/comboboxes/
then go to examples: 'Inline Single Selection'
and replace the code in code editor with the below code

https://gist.github.com/sktguha/55f1f78d0b29375ea52ff4436384bee5

if you enter any input and press enter, the tooltip 'No matches found' still persists, as shown in the image below.
image

@welcome
Copy link

welcome bot commented Aug 17, 2020

Thanks for opening your first issue! 👋
If you have found this library helpful, please star it. A maintainer will try to respond within 7 days. If you haven’t heard anything by then, please bump this thread.

@sktguha
Copy link
Author

sktguha commented Aug 21, 2020

hi, any update? Currently, I am working around it by calling .focus on the next focussable element, which triggers the onblur thus hiding the tooltip, but it will be good if there is a permanent solution for this.

@garygong
Copy link
Contributor

Thanks for opening the issue! Unfortunately, there is no team dedicated to fixing issues in this project, so it may take some time to get to get around to this. If you already have an idea for how to fix it, feel free to open a PR with the fix. Thanks again!

@sktguha
Copy link
Author

sktguha commented Aug 26, 2020

Hi @garygong thanks for the response. so basically I have solved it currently by

Currently, I am working around it by calling .focus on the next focussable element, which triggers the onblur thus hiding the tooltip,

@rlodina
Copy link

rlodina commented Sep 13, 2020

Unfortunately, there is no team dedicated to fixing issues in this project

It is an abandoned project ?

@garygong
Copy link
Contributor

I wouldn't say it's abandoned. We still review PRs and create new releases, but rely on others to submit bug fixes.

@stale
Copy link

stale bot commented Dec 19, 2020

This issue has been automatically marked as stale, because it has not had recent activity. It will be closed if no further activity occurs. Maintainers are responsible for tech debt and project health. This is most likely a new components or component feature request. Please submit a pull request for or request feedback on this feature. Thank you.

@stale stale bot added the stale label Dec 19, 2020
@lawteo
Copy link

lawteo commented Sep 7, 2021

The behaviour that @sktguha mentioned is due to the check for menuOptions.length in combobox. Here is the snippet

{menuOptions.length ? (
		menuOptions
	) : (
		<li
			className="slds-listbox__item slds-listbox__status"
			role="status"
			aria-live="polite"
		>
			<span className="slds-m-left_x-large slds-p-vertical_medium">
				{props.labels.noOptionsFound}
			</span>
		</li>
	)}

Is there a use case where the options list is empty?
If the list is not empty, entering giberish leaves the entire option list showing indicating that there is no match. This seems to be a correct behaviour as the user is expected to select from one of the options. Right?

@stale stale bot removed the stale label Sep 7, 2021
@stale
Copy link

stale bot commented Apr 18, 2022

This issue has been automatically marked as stale, because it has not had recent activity. It will be closed if no further activity occurs. Maintainers are responsible for tech debt and project health. This is most likely a new components or component feature request. Please submit a pull request for or request feedback on this feature. Thank you.

@stale stale bot added the stale label Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants