Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH DEBT] Required values should be required #22

Open
lkubb opened this issue May 29, 2024 · 0 comments
Open

[TECH DEBT] Required values should be required #22

lkubb opened this issue May 29, 2024 · 0 comments

Comments

@lkubb
Copy link
Member

lkubb commented May 29, 2024

Description of the tech debt to be addressed, include links and screenshots

Functions in this extension declare default values for all parameters, even if they are required. This results in a suboptimal interface and code layout (which needs to check for non-falsy required values).

Example:

message is a required parameter for pushover.post_message. It's the third positional argument though, after user and device, both of which are read from the configuration if unspecified. Thus one cannot simply call salt["pushover.notify"]("My message").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant