Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Package installation fails on CentOS and Rocky Linux 8 #3

Open
emansom opened this issue May 20, 2022 · 1 comment
Open

[BUG] Package installation fails on CentOS and Rocky Linux 8 #3

emansom opened this issue May 20, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@emansom
Copy link

emansom commented May 20, 2022 •
edited
Loading

Your setup

Formula commit hash / release tag

b88246c / master

Versions reports (master & minion)

[root@REDACTED ~]# salt -V
Salt Version:
          Salt: 3004.1

Dependency Versions:
          cffi: 1.11.5
      cherrypy: unknown
      dateutil: 2.6.1
     docker-py: Not Installed
         gitdb: Not Installed
     gitpython: Not Installed
        Jinja2: 2.10.1
       libgit2: 0.26.8
      M2Crypto: 0.35.2
          Mako: Not Installed
       msgpack: 0.6.2
  msgpack-pure: Not Installed
  mysql-python: Not Installed
     pycparser: 2.14
      pycrypto: Not Installed
  pycryptodome: Not Installed
        pygit2: 0.26.4
        Python: 3.6.8 (default, Apr 12 2022, 06:55:39)
  python-gnupg: Not Installed
        PyYAML: 3.12
         PyZMQ: 19.0.0
         smmap: Not Installed
       timelib: Not Installed
       Tornado: 4.5.3
           ZMQ: 4.3.4

System Versions:
          dist: rocky 8.6 Green Obsidian
        locale: UTF-8
       machine: x86_64
       release: 4.18.0-372.9.1.el8.x86_64
        system: Linux
       version: Rocky Linux 8.6 Green Obsidian

Pillar / config used

/srv/pillar/wireguard.sls

wireguard:
  interfaces:
    vpn0:
      Interface:
        Address: REDACTED
        SaveConfig: true
        ListenPort: REDACTED
        PrivateKey: REDACTED
      Peers:
        REDACTED:
          PublicKey: REDACTED
          AllowedIPs: REDACTED
          Endpoint: REDACTED
        REDACTED:
          PublicKey: REDACTED
          AllowedIPs: REDACTED
          Endpoint: REDACTED

Bug details

Describe the bug

When applying this state, it defaults to installing package wireguard-redhat, which is not available in CentOS nor Rocky Linux 8.

Steps to reproduce the bug

Running the wireguard state on a CentOS Stream or Rocky Linux 8 machine.

Expected behaviour

It defaulting to installation of the kmod-wireguard package from ELRepo and the package wireguard-tools from EPEL, as outlined in the official documentation.

Attempts to fix the bug

Fix for issue in PR #4
@emansom emansom added the bug Something isn't working label May 20, 2022
@emansom emansom changed the title [BUG] Package installations fails on CentOS and Rocky Linux 8 [BUG] Package installation fails on CentOS and Rocky Linux 8 May 20, 2022
emansom added a commit to emansom/wireguard-formula that referenced this issue May 20, 2022
@emansom
fix(package.install): proper package for CentOS and Rocky Linux 8
0d1adbc 
fixes saltstack-formulas#3

Squashed commit of the following:

commit f07bf84
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 19:06:29 2022 +0200

    fix(osfingermap): support CentOS 8

commit 7220f67
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:56:59 2022 +0200

    fix(osfingermap): set service name to wg-quick for Rocky Linux 8

commit aeb7ac7
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:48:57 2022 +0200

    fix(package.install): set name to pkgrepo state call

commit 311851a
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:44:47 2022 +0200

    fix(package.install): indent wireguard-package-install-pkg-{{ pkg_name }} correctly

commit 2793a10
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:41:38 2022 +0200

    fix(package.install): resolve conflicting state ID

commit 59d9982
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:40:20 2022 +0200

    fix(package.install): iterate over all pkgs instead

commit 773e53a
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:37:18 2022 +0200

    fix(package.install): support CentOS and Rocky Linux 8

commit 6e0d328
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:36:19 2022 +0200

    chore(precommit): update
@emansom emansom mentioned this issue May 20, 2022
Open
19 tasks
@emansom
Copy link
Author

emansom commented May 20, 2022

Opened up PR #4 to fix the issue, please merge if it's satisfactory. 😊

emansom added a commit to emansom/wireguard-formula that referenced this issue May 20, 2022
@emansom
fix(package.install): proper package for CentOS and Rocky Linux 8
6dc71d5 
fixes saltstack-formulas#3

Squashed commit of the following:

commit f07bf84
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 19:06:29 2022 +0200

    fix(osfingermap): support CentOS 8

commit 7220f67
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:56:59 2022 +0200

    fix(osfingermap): set service name to wg-quick for Rocky Linux 8

commit aeb7ac7
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:48:57 2022 +0200

    fix(package.install): set name to pkgrepo state call

commit 311851a
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:44:47 2022 +0200

    fix(package.install): indent wireguard-package-install-pkg-{{ pkg_name }} correctly

commit 2793a10
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:41:38 2022 +0200

    fix(package.install): resolve conflicting state ID

commit 59d9982
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:40:20 2022 +0200

    fix(package.install): iterate over all pkgs instead

commit 773e53a
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:37:18 2022 +0200

    fix(package.install): support CentOS and Rocky Linux 8

commit 6e0d328
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:36:19 2022 +0200

    chore(precommit): update
emansom added a commit to emansom/wireguard-formula that referenced this issue May 20, 2022
@emansom
fix(package.install): proper package for CentOS and Rocky Linux 8
f13db25 
fixes saltstack-formulas#3

Squashed commit of the following:

commit f07bf84
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 19:06:29 2022 +0200

    fix(osfingermap): support CentOS 8

commit 7220f67
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:56:59 2022 +0200

    fix(osfingermap): set service name to wg-quick for Rocky Linux 8

commit aeb7ac7
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:48:57 2022 +0200

    fix(package.install): set name to pkgrepo state call

commit 311851a
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:44:47 2022 +0200

    fix(package.install): indent wireguard-package-install-pkg-{{ pkg_name }} correctly

commit 2793a10
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:41:38 2022 +0200

    fix(package.install): resolve conflicting state ID

commit 59d9982
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:40:20 2022 +0200

    fix(package.install): iterate over all pkgs instead

commit 773e53a
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:37:18 2022 +0200

    fix(package.install): support CentOS and Rocky Linux 8

commit 6e0d328
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:36:19 2022 +0200

    chore(precommit): update
emansom added a commit to emansom/wireguard-formula that referenced this issue May 21, 2022
@emansom
fix(package.install): proper package for CentOS and Rocky Linux 8
4959e4e 
fixes saltstack-formulas#3

Squashed commit of the following:

commit f07bf84
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 19:06:29 2022 +0200

    fix(osfingermap): support CentOS 8

commit 7220f67
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:56:59 2022 +0200

    fix(osfingermap): set service name to wg-quick for Rocky Linux 8

commit aeb7ac7
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:48:57 2022 +0200

    fix(package.install): set name to pkgrepo state call

commit 311851a
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:44:47 2022 +0200

    fix(package.install): indent wireguard-package-install-pkg-{{ pkg_name }} correctly

commit 2793a10
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:41:38 2022 +0200

    fix(package.install): resolve conflicting state ID

commit 59d9982
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:40:20 2022 +0200

    fix(package.install): iterate over all pkgs instead

commit 773e53a
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:37:18 2022 +0200

    fix(package.install): support CentOS and Rocky Linux 8

commit 6e0d328
Author: Ewout van Mansom <[email protected]>
Date:   Fri May 20 18:36:19 2022 +0200

    chore(precommit): update
@gpmidi gpmidi mentioned this issue Aug 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(package.install): proper package for CentOS and Rocky Linux 8 emansom/wireguard-formula
1 participant
@emansom