Repository navigation
Commit dfa1fe2
Release 0.22.16 (#308)
* Release 0.22.16
* Fix libffi platform mismarking: source release is linux-only
The auto-update path for libffi added new entries with
platforms=["linux", "win32"], pointing at the libffi.org source
release URL. That tarball ships only configure/Makefile.am/msvcc.sh —
no ffi.h, no libffi-8.lib, no libffi-8.dll. Windows libffi has
always come from python/cpython-bin-deps, whose archive ships those
prebuilt artifacts under amd64/, win32/, and arm64/.
get_dependency_version("libffi", "win32") picks the highest-versioned
entry whose platforms list contains "win32". As soon as a new source
release (3.6.0 here) got added with win32 in its platforms, it
shadowed the cpython-bin-deps entry (3.4.4) for win32 — so the build
fetched the source tarball, and _ctypes.vcxproj failed with
`error C1083: Cannot open include file: 'ffi.h'` across every Windows
matrix entry on PR #308.
Same root cause as the existing 3.5.2 entry being ["linux"]-only:
that was effectively the correct state, just never enforced in the
auto-updater.
Two changes:
- relenv/pyversions.py: drop "win32" from the platforms list the
auto-updater writes for new libffi source releases. The
detect_cpython_bin_deps_versions() branch immediately below
handles the Windows-side entry (platforms=["win32"]) and stays
untouched.
- relenv/python-versions.json: drop "win32" from the existing
3.6.0 entry so the win32 build falls back to 3.4.4 cpython-bin-deps
and CI unblocks without waiting on a fresh auto-update run.
Auto-updater bug only; libffi 3.6.0 itself is fine on Linux.
---------
Co-authored-by: dwoz <1527763+dwoz@users.noreply.github.com>
Co-authored-by: Daniel A. Wozniak <daniel.wozniak@broadcom.com>1 parent cea2101 commit dfa1fe2
4 files changed
Lines changed: 42 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
1 | 9 | | |
2 | 10 | | |
3 | 11 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
322 | 322 | | |
323 | 323 | | |
324 | 324 | | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
325 | 335 | | |
326 | 336 | | |
327 | 337 | | |
| |||
358 | 368 | | |
359 | 369 | | |
360 | 370 | | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
361 | 378 | | |
362 | 379 | | |
363 | 380 | | |
| |||
540 | 557 | | |
541 | 558 | | |
542 | 559 | | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
543 | 569 | | |
544 | 570 | | |
545 | 571 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
723 | 723 | | |
724 | 724 | | |
725 | 725 | | |
726 | | - | |
| 726 | + | |
| 727 | + | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
727 | 733 | | |
728 | 734 | | |
729 | 735 | | |
| |||
0 commit comments