Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info: Responsive page scaling and SCEditor resizing #932

Open
MioVisman opened this issue Apr 4, 2023 · 1 comment
Open

Info: Responsive page scaling and SCEditor resizing #932

MioVisman opened this issue Apr 4, 2023 · 1 comment
Assignees
Labels
Milestone

Comments

@MioVisman
Copy link

Firefox 108

  1. If we do not specify the width parameter in sceditor.create(), then we get a violation of the dimensions of SCEditor when scaling the page:

test1

  1. If we specify
    width: '100%'
    , then everything is OK:

test2

@samclarke samclarke added the Bug label Apr 4, 2023
@samclarke
Copy link
Owner

Thanks for reporting.

For backwards compatibility, the editors default behaviour is use the same pixel dimensions as the textarea it replaces which prevents the editor from resizing. It's something I'd like to change but it needs to be backwards compatible or part of a major version which is why it hasn't so far.

Although thinking about it, the original textarea's size could be converted to a percentage and used instead. That should still be backwards compatible while being responsive.

@samclarke samclarke self-assigned this Apr 4, 2023
@samclarke samclarke added this to the v3.3.0 milestone Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants