Conversation
Owner
|
Cool! To clarify, should we hold off on merging this until 1.51 is out? |
Contributor
Author
|
Yes, with the release of 1.51, this pr can be committed(baring any future merge conflicts). |
Pat-Lafon
force-pushed
the
brilirs-stable
branch
from
b84c7da to
9071d8f
Compare
Contributor
Author
|
I have been bamboozled, 4 days ago, the version for stabilizing the or_patterns feature was changed to 1.53 which becomes the stable version on June 17th. rust-lang/rust#79278 |
Owner
|
Ah! That ol' stabilization treadmill. 😃 |
Contributor
Author
|
4 months later, this commit now works as expected on the latest stable release and is ready to be merged. |
Owner
|
Yay!! Thanks, @Pat-Lafon!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Rust 1.51,
#![feature(or_patterns)]should be stablized. This pr movesbrilirsback on to the stable channel. This pr is dependent of #122.See https://forge.rust-lang.org/ for the rust release schedule. The current date is March 25th.