You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As noted in #1863, when reading @SQ headers sam_hdr_create() records the value for the last LN: and SN: tags, while refs_from_header() uses the result from sam_hrecs_find_key() which is the first one. This leads to a possible discrepancy in how such lines are interpreted by the SAM- and CRAM- reading code.
As such lines are invalid according to the specification ("Within each (non-@CO) header line, no field tag may appear more than once...") it might be best to reject such inputs by enforcing the one-tag rule. Hopefully the number of files that would be rejected as a result will be very small, if any, and it will prevent any possibility of inconsistent interpretation.
The text was updated successfully, but these errors were encountered:
As noted in #1863, when reading
@SQ
headerssam_hdr_create()
records the value for the lastLN:
andSN:
tags, whilerefs_from_header()
uses the result fromsam_hrecs_find_key()
which is the first one. This leads to a possible discrepancy in how such lines are interpreted by the SAM- and CRAM- reading code.As such lines are invalid according to the specification ("Within each (non-
@CO
) header line, no field tag may appear more than once...") it might be best to reject such inputs by enforcing the one-tag rule. Hopefully the number of files that would be rejected as a result will be very small, if any, and it will prevent any possibility of inconsistent interpretation.The text was updated successfully, but these errors were encountered: