Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename JournalArticle to Article #86

Open
ghost opened this issue Jun 26, 2018 · 1 comment
Open

Rename JournalArticle to Article #86

ghost opened this issue Jun 26, 2018 · 1 comment
Labels
technical debt

Comments

@ghost
Copy link

ghost commented Jun 26, 2018 •
edited by ghost
Loading

cf eprints Article:
An article in a journal, magazine, newspaper. Not necessarily peer-reviewed. May be an electronic-only medium, such as an online journal or news website.

Makes the model more generic.

bear in mind this would break any existing implementations

what might be better is to have Article and JournalArticle, and have the latter inherit from the former?
@ghost
Copy link
Author

ghost commented Oct 25, 2018

This will become a breaking change unless it's done before Warburg goes live.

@ghost ghost added the technical debt label Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
0 participants