-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add display of annotations to Markers component (UI) #649
Comments
Since almost all the parsing work is done via #751 and #753, I think we are in a good place to start the UI work for Annotations component. |
@Dananji Sounds good to me. |
@joncameron and @elynema Do you happen to remember why we put the following done looks like for displaying annotations with a given motivation (as a prop)? I can't seem to remember whether this was a requirement came from AVAnnotate folks or something we discussed implementing in the
There doesn't seem to be any filtering done based on motivation in both Aviary and AVAnnotate's annotations display. |
@Dananji This is not necessarily based on the AVAnnotate or Aviary use case, but more that it seems useful for Ramp users to be able to define which annotation motivations are displayed in the Annotations component? |
Yes, that sounds good. @elynema Does it make sense to set the prop as follows? |
@Dananji Yes, that sounds right to me. |
Description
For AVAnnotation grant effort, Ramp needs to be able to display annotations more generically. The Markers component can be re-used for this purpose. The name of the component can be set through a prop.
Questions
Done Looks Like
Extend Markers display component
Provide a multi-select filter drop-down at the top allowing users to select one or more annotation sets to display. When not expanded, the drop-down should say how many sets are selected.
Display annotations with motivation commenting (AVAnnotate) or supplementing (Aviary)
For a given annotation body, the label/value pair displays, ex: "Title: Bladderball"
If there are multiple annotation bodies, all should be displayed
If there is an annotation body with purpose=tagging, that value should be displayed as the label for the annotation
Props exist for: component heading, whether or not the tab scrolls, which motivation annotations should be displayed
Time should be displayed as either a single time (if the annotation reference a timepoint or a range if referenced in annotation). If a range, the entire range should link to the starting timepoint in the range.
Do not display markers on the time rail for first iteration
If not displaying highlighting annotations (markers), then annotations should display with timepoint/range and label(s) on the first line, with annotation text below and likely to be muti-line. If the annotation text is >6 lines, implement some kind of expand to show the entire annotation text, which could be very long
The text was updated successfully, but these errors were encountered: