Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull to refresh view doesn't always hide cleanly #131

Open
lordkev opened this issue May 29, 2013 · 6 comments
Open

Pull to refresh view doesn't always hide cleanly #131

lordkev opened this issue May 29, 2013 · 6 comments

Comments

@lordkev
Copy link
Contributor

lordkev commented May 29, 2013

I'm running into an issue where the pull to refresh view doesn't always hide cleanly after calling stopAnimating. I haven't been able to nail down exactly what conditions it occurs under, aside that it appears somewhat "random" in my use.

I did however nail it down to this commit that is causing the issue: b88f78d (from #99)

If I revert this commit then the pull to refresh view always hides cleanly, but I'm not sure how best to solve it so that @pilot34's use case also works.

Any ideas?

@pilot34
Copy link
Contributor

pilot34 commented May 31, 2013

It's ok if you revert my commit if nobody has the same problem. I'm working in branch

@raphaeloliveira
Copy link

@samvermette I had the same problem, the pull to refresh sometime only partial hide. I solved this problem as suggested @lordkev reverting the commit. Could you do that in the cocoa pods version?

JRG-Developer added a commit to JRG-Developer/SVPullToRefresh that referenced this issue Aug 23, 2013
JRG-Developer added a commit to JRG-Developer/SVPullToRefresh that referenced this issue Sep 4, 2013
… to refresh view would not hide cleanly"

This reverts commit bb890c8.
samvermette added a commit that referenced this issue Sep 26, 2013
@zhuhao528
Copy link

I had the same problem with latest version. i found that stop stopAnimating is performed,but it do nothing when the network is closed or network is quick. how to solved it.

@fustalol
Copy link

same here.

@mattmcneeney
Copy link

I was also affected by this issue when using with a very fast internet connection, leading to a very short time period between calls to startAnimating() and stopAnimating().

Since the podspec hasn't been updated in 3 years, the fix referenced that has been committed to master hasn't made it through to the default pod yet.

You can workaround this for now by replacing

pod 'SVPullToRefresh'

with

pod 'SVPullToRefresh', :git => 'https://github.com/samvermette/SVPullToRefresh.git', :branch => 'master'

@jeffctown
Copy link

Thanks @mattmcneeney! Spent 2 hours debugging this before I saw your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants