contentInset not suitable with iOS7

[cookingios]

contentInset not suitable with iOS7

[kyo9999]

ios7 have problem too, do you change it?

[bassrock]

same problem here? any ideas to fix this properly?

[kyo9999]

i fix it like this:
-(void)viewDidAppear:(BOOL)animated
{
// setup the pull-to-refresh view
__weak UITableView *weaktableview = MyUITableView;
[self.MyUITableView addPullToRefreshWithActionHandler:^{
NSLog(@"refresh dataSource");
//[_AppDelegate.coreDataController iCloudAccountChanged:nil];
[weaktableview.pullToRefreshView performSelector:@selector(stopAnimating) withObject:nil afterDelay:1];
}];

[fanyj]

I test it with iOS7. It seems the work around by @kyo9999 can fix this problem. The problem was caused by iOS7 automaticallyAdjustsScrollViewInsets property. The default value of this property is YES. Simply disable it like this can also fix this problem. Remeber to check ios version if your need to support earlier ios version.

- (void)viewDidLoad
{
    [super viewDidLoad];

    self.automaticallyAdjustsScrollViewInsets = NO;
    // Some other code...
}

[siburb]

Beautiful! Thanks @fanyj, I wasn't looking forward to debugging that one!

[GaetanJuvin]

Nice @fanyj :-)

[sqlumee]

It just work for the first time, but after the first pull the contentInset is broken again

[siburb]

Strange - I'm finding the opposite. I was only ever having the problem on the first pull prior to this fix, and now I don't have it at all.

[fanyj]

@sqlumee As a side-effect, my solution disable the "automaticallyAdjustsScrollViewInsets" behavior. You may need to set contentInset manully after your view loaded.

- (void)viewDidLoad
{
    [super viewDidLoad];

    // Manully set contentInset.
    UIEdgeInset currentInset = self.tableView.contentInset;
    currentInset.top = self.navigationController.navigationBar.bounds.size.height;
    if (SYSTEM_VERSION_HIGHER_OR_EQUAL_THAN(@"7.0")) {
        self.automaticallyAdjustsScrollViewInsets = NO;
        // On iOS7, you need plus the height of status bar.
        currentInset.top += STATUS_BAR_HEIGHT;
    }
    self.tableView.contentInset = currentInset;

    // Some other code...
}

Additonally, try it on the lastest commit.

[sqlumee]

is it going to be fixed in SVPullToRefresh? or something we have to do in each VC since now?

[sagiwei]

@fanyj , nice solution, but I found set contentInset.top may cause animation lost when use triggerPullToRefresh to trigger refresh manually. The problem may caused by code in UIScrollView+SVPullToRefresh.m:

- (void)startAnimating{
    // if(fequalzero(self.scrollView.contentOffset.y) {
    if(fequalzero(self.scrollView.contentOffset.y + self.originalTopInset)){
        // [self.scrollView setContentOffset:CGPointMake(self.scrollView.contentOffset.x, -self.frame.size.height) animated:YES];
        [self.scrollView setContentOffset:CGPointMake(self.scrollView.contentOffset.x, -(self.frame.size.height+self.originalTopInset)) animated:YES];
        self.wasTriggeredByUser = NO;
    }
    else
        self.wasTriggeredByUser = YES;

    self.state = SVPullToRefreshStateLoading;
}

Don't forget self.originlTopInset, now it work fine for me in iOS7 and iOS6.

[limboy]

scrollView's contentInset is set after viewDidLoad when automaticallyAdjustsScrollViewInsets is set YES, so when addPullToRefreshWithActionHandler in viewDidLoad, SVPullToRefresh's originalTopInset is still 0, a dirty fix is use dispatch_after.

double delayInSeconds = 0.1;
dispatch_time_t popTime = dispatch_time(DISPATCH_TIME_NOW, (int64_t)(delayInSeconds * NSEC_PER_SEC));
    dispatch_after(popTime, dispatch_get_main_queue(), ^(void){
        // 设置下拉刷新
        [self.tableView addPullToRefreshWithActionHandler:^{
        }];
    }];
});

[zwzmzd]

@sagiwei A good sloution, It works for my project.

[zquintana]

Is this going to be fixed in the main repo?

[mactive]

@fanyj is worked in iOS 7. THX

[TouchG]

Here is what I do：

• (void)viewDidLoad
  {
  [super viewDidLoad];

  // Manully set contentInset.
  UIEdgeInset currentInset = self.tableView.contentInset;
  currentInset.top = self.navigationController.navigationBar.bounds.size.height;
  if (SYSTEM_VERSION_HIGHER_OR_EQUAL_THAN(@"7.0")) {

       self.edgesForExtendedLayout = UIRectEdgeNone;
  

  }

  // Some other code…
  }

Basically，It's same with @fanyj ,but you don't care about the contentInsets.Also you can deselect "Under The Top Bar" in Attributes Inspector from you storyboard or nib file.

[ieliwb]

I used @sagiwei fixed.
thanks.

[anhuijhy]

if we set automaticallyAdjustsScrollViewInsets we can modify the code as below
view.originalTopInset = self.contentInset.top + NavBarHeight + StatusBarHeight;
is this a way?

[anhuijhy]

if we set automaticallyAdjustsScrollViewInsets = YES we can modify the code as below
view.originalTopInset = self.contentInset.top + NavBarHeight + StatusBarHeight;
is this a way?

[Vishal2Deshai]

@fanyj thanks for Solving My Problem.

Only one line Solved My Issue (dance).

[gclsoft]

I've solved by the way @fanyj said. But when I call [self.tableView.pullToRefreshView startAnimating];, the SVPullToRefresh doesn't display, only when I pull down the tableview by hand, it can display. How to solve it?

- (void)viewDidLoad {
    [super viewDidLoad];

    // Manully set contentInset.
    UIEdgeInsets currentInset = self.tableView.contentInset;
    currentInset.top = self.navigationController.navigationBar.bounds.size.height;
    //if (SYSTEM_VERSION_HIGHER_OR_EQUAL_THAN(@"7.0")) {
    self.automaticallyAdjustsScrollViewInsets = NO;
    // On iOS7, you need plus the height of status bar.
    CGRect rcStatus=[[UIApplication sharedApplication] statusBarFrame];
    currentInset.top += rcStatus.size.height;
    // }
    self.tableView.contentInset = currentInset;
    //self.edgesForExtendedLayout = UIRectEdgeNone;

[sagiwei]

@gclsoft see my comment above, same problem.

[cmcnab]

+1 for sagiwei's comment from Sep 24, 2013. Manually triggering pull to refresh wasn't working for me until I modified those lines.

[VincentSit]

@sagiwei Thanks.