Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Remove jQuery dependency #289

Open
leizhao4 opened this issue Mar 22, 2017 · 5 comments
Open

[Feature Request] Remove jQuery dependency #289

leizhao4 opened this issue Mar 22, 2017 · 5 comments

Comments

@leizhao4
Copy link

leizhao4 commented Mar 22, 2017

Related to #256 but in a broader sense. Since Ember could make jQuery optional, why not we use all vanilla JavaScript instead of relying on jQuery?

@san650
Copy link
Owner

san650 commented Mar 27, 2017

@leizhao4 this would be great! I think it could be an objective for the 2.0

I think right now the main dependency with jQuery are the custom jQuery selectors (:contains, etc.). We need to come up with a migration plan and start deprecating features that relay on jQuery.

@juanazam
Copy link
Collaborator

@san650 rather than deprecating those features, it woud be great to have an optin way of using them if you install jQuery. Thoughts?

@san650
Copy link
Owner

san650 commented Mar 30, 2017

We could start reworking the internals to replace jQuery on places where it makes sense first. Like using native events for triggerable and querySelector and querySelectorAll.

@ming-codes
Copy link

Would it be possible to configure jQuery as a “dev” dependency that’s only used in testing? That fulfills the requirement that we’re not shipping jQuery to production while still be able to use jQuery in tests.

@ro0gr
Copy link
Collaborator

ro0gr commented Oct 16, 2017

@ming-codes when you enable jQuery then Ember will immediately setup Ember.$.
It's also possible to get conflicts with jQuery plugins if they occasionally remained in your app.
Then when you disable jQuery for prod mode it would be impropely(I believe so) tested app.

If you are interested in reliable jQuery-less solution I would suggest to test #325. Here I've tried to properly isolate jQuery without a side effects.

@ro0gr ro0gr mentioned this issue Nov 11, 2017
1 task
@ro0gr ro0gr mentioned this issue Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants