Skip to content

Add workers argument to create_mirror_for_all_specs function in distribution script #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnhealy2 merged 3 commits into from
Jan 19, 2026
Merged

Add workers argument to create_mirror_for_all_specs function in distribution script #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0755714
Add workers argument to create_all_mirror_specs function in distribut…
akimler Nov 4, 2025
a3ef1eb
Merge branch 'main' into main
jnhealy2 Jan 19, 2026
35a28aa
Remove issue with test_failsWithNoProject error with using capsys
akimler Jan 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions manager/manager_cmds/distribution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,7 @@ def configure_source_mirror(self):
mirror_specs=filter_externals(self.environment_to_package.all_specs()),
path=self.source_mirror,
skip_unstable_versions=False,
workers=spack.config.determine_number_of_jobs(parallel=True),
)

with self.env:
Expand All @@ -320,6 +321,7 @@ def configure_source_mirror(self):
mirror_specs=filter_externals(self.env.all_specs()),
path=self.source_mirror,
skip_unstable_versions=False,
workers=spack.config.determine_number_of_jobs(parallel=True),
)
mirror_path = os.path.join(
os.path.relpath(self.path, self.env.path), os.path.basename(self.source_mirror)
Expand Down
3 changes: 1 addition & 2 deletions tests/test_external.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def setupExternalEnv(tmpdir, has_view=True):
return env_path


def test_failsWithNoProject(tmpdir, capsys):
def test_failsWithNoProject(tmpdir):
yaml_file = """spack:
view: true
specs: [mpileaks]"""
Expand All @@ -110,7 +110,6 @@ def test_failsWithNoProject(tmpdir, capsys):
with pytest.raises(SystemExit):
with ev.Environment("test"):
external(None, args)
assert "No project detected." in capsys.readouterr()


def test_errorsIfThereIsNoView(tmpdir, on_moonlight):
Expand Down