Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL-310 Destruction feature to move labware to LabWhere 'destroyed' location (C=M) #339

Closed
2 tasks done
KatyTaylor opened this issue Mar 3, 2022 · 9 comments · Fixed by #608, sanger/labwhere#783, #612 or #626
Closed
2 tasks done
Assignees
Labels
Labware Destruction Size: L Large - large effort & risk

Comments

@KatyTaylor
Copy link
Contributor

KatyTaylor commented Mar 3, 2022

User story
As a Sample Management or Heron user I would like the destruction feature of Asset Audits to move the labware to a special location in LabWhere that I use to indicate that labware are destroyed, so that I don't have to go to LabWhere separately to do this.

Who are the primary contacts for this story
Danni & Anna G

Acceptance criteria
To be considered successful the solution must allow:

  • Labware marked for destruction in Asset Audits should also have their locations updated in LabWhere, to a special 'destroyed' location.
  • There is messaging on the page to explain this is what will happen, and feedback to say whether the update in LabWhere was successful or not.

Additional context
Asset Audits has its own event-based way of marking a labware as destroyed. However, the Asset Audits feature is not being used, and the accepted way of marking labware as destroyed is to use these special locations in LabWhere.

@KatyTaylor KatyTaylor added the Enhancement New feature or request label Mar 3, 2022
@KatyTaylor KatyTaylor changed the title DPL-310 Destruction feature to move labware to LabWhere 'destroyed' location DPL-310 Destruction feature to move labware to LabWhere 'destroyed' location (C=M) Mar 3, 2022
@KatyTaylor KatyTaylor changed the title DPL-310 Destruction feature to move labware to LabWhere 'destroyed' location (C=M) DPL-310 Destruction feature to move labware to LabWhere 'destroyed' location (C=M, V=4) Mar 3, 2022
@KatyTaylor KatyTaylor changed the title DPL-310 Destruction feature to move labware to LabWhere 'destroyed' location (C=M, V=4) DPL-310 Destruction feature to move labware to LabWhere 'destroyed' location (C=M, V=3) Mar 3, 2022
@TWJW-SANGER
Copy link

There are a 6 "Destroyed" locations within labwhere (search for 'Destroyed'). We may need clarity on which one to use or allow users to choose....

@SujitDey2022
Copy link

A process improvement requirement to help reduce manual efforts when destroying multiple samples and derivatives.

@SujitDey2022 SujitDey2022 added the Should've MoSCoW Prioritization - Should Have Capability/Feature label Aug 22, 2023
@SujitDey2022 SujitDey2022 changed the title DPL-310 Destruction feature to move labware to LabWhere 'destroyed' location (C=M, V=3) DPL-310 Destruction feature to move labware to LabWhere 'destroyed' location (C=M) Sep 4, 2023
@SujitDey2022 SujitDey2022 added Size: L Large - large effort & risk and removed Should've MoSCoW Prioritization - Should Have Capability/Feature labels Nov 21, 2023
@SujitDey2022
Copy link

09Jan2024 - Team Discussion

  1. Which of the 6 Destroyed location is to be considered as 'Destroyed' location?
  2. Do we need to identify the need for data migration from some or all locations to the new one?

@SujitDey2022
Copy link

17Jan2024 - Team Discussion

  1. Create new single location to be created in 'Labwhere' with destroyed labware type.
  2. Currently tableau is used to report on archived samples which may also have location information.
  3. Nice to have people destroying samples using Asset Audits and only limited access for the ones who can do it in 'Labwhere'

@yoldas yoldas self-assigned this May 17, 2024
@yoldas
Copy link
Member

yoldas commented May 22, 2024

Notes:

  • Destroying labware process does not require instrument barcode.
destroy_labware:
  name: Destroying labware
  request_instrument: false
  visual_check_required: false
  • Asset Audits uses Sequencescape API for users, however Labwhere has its own users table.

@yoldas
Copy link
Member

yoldas commented May 23, 2024

Assumptions

My current assumption is that barcode of the user from SS matches the Labwhere user barcode. If they are the same, Asset Audit post for "Destroying Labware" process becomes simply including a second post to Labwhere to set the unique Destroyed location for the listed barcodes.

When user selects Asset Audits "Destroying Labware" process, we will display info about what will happen. After submit, any errors from Asset Audit post and the secondary Labwhere "post" will be consolidated and shown. On success, a feedback will be shown about the destruction and the location is also set in Labwhere.

Existing Form Screenshots

Asset Audits Labwhere
Screenshot 2024-05-23 at 10 04 54 Screenshot 2024-05-23 at 10 06 34

Database schemas

Asset Audits (SS) Labwhere Users
Screenshot 2024-05-23 at 10 38 36 Screenshot 2024-05-23 at 10 34 33

How to do a "Two phase commit" involving two apps after validation?

WIP

@yoldas
Copy link
Member

yoldas commented May 23, 2024

  • Create Story1: Updating swipecard in SS Profile will update Labware swipecard as well.
  • Create Story2: Create an endpoint in Labwhere for sync.ing barcode as well and provide a UI to sync.
  • Write down a confluence page to explain the auth and relationships of the apps.

@yoldas
Copy link
Member

yoldas commented May 23, 2024

I have done some further research and written a Confluence article:
User authentication, swipe-cards, barcodes and relationships between apps

@yoldas
Copy link
Member

yoldas commented Jun 3, 2024

@yoldas yoldas linked a pull request Jun 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment