Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y25-171 - Add display of Current Volume for plates #4712

Open
1 task
StephenHulme opened this issue Mar 4, 2025 · 3 comments · May be fixed by #4710
Open
1 task

Y25-171 - Add display of Current Volume for plates #4712

StephenHulme opened this issue Mar 4, 2025 · 3 comments · May be fixed by #4710
Assignees
Labels
Cherrypicking Enhancement New feature or request Size: S Small - low effort & risk Value: 4 Value to the insitute is high

Comments

@StephenHulme
Copy link
Contributor

StephenHulme commented Mar 4, 2025

User story

Coming from Y24-382, is a request to include the Current Volume of the plates for better situational awareness in the lab.

Who are the primary contacts for this story

Liz C

Who is the nominated tester for UAT

Liz C

Acceptance criteria

Consider if these features can be featured flagged to decouple testing and deployment.
To be considered successful the solution must allow:

  • the current volume of the selected plate, along with other QC information

Dependencies

This story is blocked by the following dependencies:

  • None

References
This story has a non-blocking relationship with:

Additional context

... you mentioned that the “current” volume is updated after bed verification in the cherrypicking process, but this isn’t viewable in the SS page.

... also thought that we could make a new story to do with improving access to these volumes – making sure there’s the various screens and reports in Sequencescape show you the right thing and that it’s clear which volumes they’re showing you (because questions have come up around this area!).

Deployment notes

Add any details that should be noted when deploying this feature. For example, is a database migration needed, a specifc rake task or other script that needs to be run, a dependency on another application or service that needs to be released first etc?
These notes are intended to ensure the developers releasing the feature know what needs to be done.

Add any other context or screenshots about the feature request here.

@StephenHulme StephenHulme added the Enhancement New feature or request label Mar 4, 2025
@psd-issuer psd-issuer bot changed the title Add display of Current Volume for plates Y25-171 - Add display of Current Volume for plates Mar 4, 2025
@StephenHulme StephenHulme added Size: S Small - low effort & risk Value: 4 Value to the insitute is high labels Mar 4, 2025
@StephenHulme StephenHulme self-assigned this Mar 4, 2025
@StephenHulme StephenHulme linked a pull request Mar 4, 2025 that will close this issue
@StephenHulme StephenHulme changed the title Y25-171 - Add display of Current Volume for plates Y25-171: Add display of Current Volume for plates Mar 4, 2025
@StephenHulme StephenHulme changed the title Y25-171: Add display of Current Volume for plates Y25-171 - Add display of Current Volume for plates Mar 4, 2025
@KatyTaylor
Copy link
Contributor

@StephenHulme , apologies if I'm going over ground we've already covered here.

Do you have a good understanding of when the 'current volume' would differ from the 'measured volume'? Is it that, after a cherrypick, the 'current volume' would have been updated, but the 'measured volume' wouldn't?

I think, if we add both onto the page, we should add a bit of explanatory text as to the difference between the two. I see you've put the asterisk with 'Calculated, not measured' - that's a good start.

@StephenHulme
Copy link
Contributor Author

The 'current volume' is updated after bed verification, but the 'measured volume' is not updated.
The 'measured volume' is only updated when a QC file is uploaded.
The research story contains more details about this.

Good suggestion about including an explanation, I'll add some suitable text.

@KatyTaylor
Copy link
Contributor

The 'current volume' is updated after bed verification, but the 'measured volume' is not updated. The 'measured volume' is only updated when a QC file is uploaded. The research story contains more details about this.

Good suggestion about including an explanation, I'll add some suitable text.

Thank you. One more question!

So 'bed verification' --updates--> 'current volume'
And 'QC file' --updates--> 'measured volume'

Does 'QC file' also update 'current volume'? It would make intuitive sense to me if it did - imagine the scenario where they have done a cherrypick, then waited ages, then want to do another cherrypick, but are not confident in the volume, so they re-measure the volume. Then, you'd want the LIMS to treat that value as the 'real' value, when considering how much there is in the source well before a cherrypick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cherrypicking Enhancement New feature or request Size: S Small - low effort & risk Value: 4 Value to the insitute is high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants