You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Renames four document-pane telemetry event name strings from camelCase to Title Case, per SAPP-3817. The exported JS identifiers (DocumentURLCopied, etc.) are unchanged - only the emitted event name values change.
DocumentURLCopied -> Document URL Copied
DocumentIDCopied -> Document ID Copied
InlineChangesSwitchedOn -> Inline Changes Switched On
InlineChangesSwitchedOff -> Inline Changes Switched Off
Resolves SAPP-3817.
What to review
Confirm only the name: literals changed in documentPanes.telemetry.ts and that the exported identifiers are untouched.
Confirm the two updated assertions in CopyDocumentActions.test.tsx match the new Title Case names.
Most importantly: confirm the downstream dbt/Looker migration is planned and sequenced (see warning above) before this is marked ready.
Testing
pnpm run test run CopyDocumentActions - 13 passed. The two assertions covering the URL- and ID-copied events were updated to the new names and pass.
efps — editor "frames per second". The number of updates assumed to be possible within a second.
Derived from input latency. efps = 1000 / input_latency
Detailed information
🏠 Reference result
The performance result of sanity@latest
Benchmark
latency
p75
p90
p99
blocking time
test duration
arrayI18n (simple-en)
21ms
26ms
34ms
58ms
5ms
7.0s
article (title)
26ms
29ms
38ms
75ms
38ms
8.0s
article (body)
20ms
24ms
35ms
97ms
214ms
5.6s
article (string inside object)
22ms
27ms
39ms
76ms
34ms
6.7s
article (string inside array)
24ms
26ms
29ms
66ms
2ms
7.0s
recipe (name)
11ms
13ms
15ms
36ms
2ms
5.4s
recipe (description)
22ms
26ms
31ms
53ms
0ms
4.8s
recipe (instructions)
10ms
12ms
13ms
29ms
0ms
3.2s
singleString (stringField)
7ms
11ms
13ms
21ms
0ms
4.7s
synthetic (title)
18ms
19ms
23ms
87ms
1399ms
9.3s
synthetic (string inside object)
20ms
24ms
84ms
102ms
1329ms
9.5s
🧪 Experiment result
The performance result of this branch
Benchmark
latency
p75
p90
p99
blocking time
test duration
arrayI18n (simple-en)
19ms
26ms
42ms
79ms
37ms
6.8s
article (title)
27ms
31ms
35ms
71ms
24ms
7.9s
article (body)
20ms
26ms
37ms
89ms
227ms
5.4s
article (string inside object)
24ms
27ms
39ms
61ms
28ms
6.7s
article (string inside array)
24ms
27ms
37ms
73ms
14ms
7.2s
recipe (name)
11ms
13ms
16ms
38ms
0ms
5.5s
recipe (description)
23ms
24ms
27ms
48ms
0ms
4.7s
recipe (instructions)
10ms
12ms
15ms
36ms
0ms
3.3s
singleString (stringField)
8ms
10ms
12ms
24ms
0ms
4.8s
synthetic (title)
18ms
21ms
26ms
93ms
1498ms
9.7s
synthetic (string inside object)
21ms
28ms
44ms
97ms
1351ms
9.7s
📚 Glossary
column definitions
benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
test duration — how long the test run took to complete.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames four document-pane telemetry event
namestrings from camelCase to Title Case, per SAPP-3817. The exported JS identifiers (DocumentURLCopied, etc.) are unchanged - only the emitted eventnamevalues change.DocumentURLCopied->Document URL CopiedDocumentIDCopied->Document ID CopiedInlineChangesSwitchedOn->Inline Changes Switched OnInlineChangesSwitchedOff->Inline Changes Switched OffResolves SAPP-3817.
What to review
name:literals changed indocumentPanes.telemetry.tsand that the exported identifiers are untouched.CopyDocumentActions.test.tsxmatch the new Title Case names.Testing
pnpm run test run CopyDocumentActions- 13 passed. The two assertions covering the URL- and ID-copied events were updated to the new names and pass.Notes for release
N/A