From a8fb5c2fcaf6366877b51625b852ae96fd307370 Mon Sep 17 00:00:00 2001 From: Cody Olsen Date: Sat, 21 Dec 2024 20:16:13 +0100 Subject: [PATCH] fix: react 19 typings --- packages/presentation/src/editor/ContentEditor.tsx | 1 + packages/presentation/src/editor/usePreviewState.ts | 1 + packages/presentation/src/overlays/schema/SchemaIcon.tsx | 7 +------ packages/presentation/src/overlays/schema/extract.ts | 3 +++ .../src/overlay-components/components/InsertMenu.tsx | 1 - 5 files changed, 6 insertions(+), 7 deletions(-) diff --git a/packages/presentation/src/editor/ContentEditor.tsx b/packages/presentation/src/editor/ContentEditor.tsx index 3552e055a..2252c32be 100644 --- a/packages/presentation/src/editor/ContentEditor.tsx +++ b/packages/presentation/src/editor/ContentEditor.tsx @@ -67,6 +67,7 @@ export function ContentEditor(props: { [mainDocumentState, schema], ) + // @ts-expect-error fix later const previewState = usePreviewState(mainDocumentState?.document?._id || '', schemaType) const preview = useMemo(() => { diff --git a/packages/presentation/src/editor/usePreviewState.ts b/packages/presentation/src/editor/usePreviewState.ts index 54b173a17..acd411a51 100644 --- a/packages/presentation/src/editor/usePreviewState.ts +++ b/packages/presentation/src/editor/usePreviewState.ts @@ -23,6 +23,7 @@ export default function usePreviewState(documentId: string, schemaType?: SchemaT } const subscription = getPreviewStateObservable( documentPreviewStore, + // @ts-expect-error fix later schemaType, documentId, '', diff --git a/packages/presentation/src/overlays/schema/SchemaIcon.tsx b/packages/presentation/src/overlays/schema/SchemaIcon.tsx index fbd443f8f..210596309 100644 --- a/packages/presentation/src/overlays/schema/SchemaIcon.tsx +++ b/packages/presentation/src/overlays/schema/SchemaIcon.tsx @@ -14,12 +14,7 @@ export const SchemaIcon: FunctionComponent<{ return Icon ? ( - {isValidElement(Icon) ? ( - Icon - ) : ( - // @ts-expect-error fix later - - )} + {isValidElement(Icon) ? Icon : } ) : null diff --git a/packages/presentation/src/overlays/schema/extract.ts b/packages/presentation/src/overlays/schema/extract.ts index b64651227..4dd9efb3d 100644 --- a/packages/presentation/src/overlays/schema/extract.ts +++ b/packages/presentation/src/overlays/schema/extract.ts @@ -207,6 +207,7 @@ export function extractSchema(workspace: Workspace, theme: ThemeContextValue): S const inlineFields = new Set() const {schema: schemaDef, basePath} = workspace + // @ts-expect-error fix later const sortedSchemaTypeNames = sortByDependencies(schemaDef) return sortedSchemaTypeNames .map((typeName) => { @@ -214,6 +215,7 @@ export function extractSchema(workspace: Workspace, theme: ThemeContextValue): S if (schemaType === undefined) { return } + // @ts-expect-error fix later const base = convertBaseType(schemaType) if (base === null) { @@ -221,6 +223,7 @@ export function extractSchema(workspace: Workspace, theme: ThemeContextValue): S } if (base.type === 'type') { + // @ts-expect-error fix later inlineFields.add(schemaType) } diff --git a/packages/visual-editing/src/overlay-components/components/InsertMenu.tsx b/packages/visual-editing/src/overlay-components/components/InsertMenu.tsx index 0ea50bbd3..2396f2db9 100644 --- a/packages/visual-editing/src/overlay-components/components/InsertMenu.tsx +++ b/packages/visual-editing/src/overlay-components/components/InsertMenu.tsx @@ -47,7 +47,6 @@ export const InsertMenu: FunctionComponent = (props) => { ...type, icon: getNodeIcon(type), }))} - // @ts-expect-error fix typings later onSelect={onSelect} views={views} />