From 9122079319dcc77af99f1ff6277ad12533d15741 Mon Sep 17 00:00:00 2001
From: mahdibenromdhane <mahdi.benromdhane@esprit.tn>
Date: Mon, 9 Jan 2023 23:41:01 +0100
Subject: [PATCH 1/4] Show ocpi modal buttons on create mode

---
 .../endpoints/endpoint/settings-ocpi-endpoint.component.html  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html
index 80060e1e48..3e37375cd5 100644
--- a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html
+++ b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html
@@ -98,7 +98,7 @@
                   </div>
                 </div>
                 <div class="col-md-4 text-end">
-                  <button mat-raised-button color="primary" *ngIf="currentEndpoint.canGenerateLocalToken" (click)="generateLocalToken(formGroup.value)">
+                  <button mat-raised-button color="primary" *ngIf="(currentEndpoint | json) === '{}' || currentEndpoint.canGenerateLocalToken" (click)="generateLocalToken(formGroup.value)">
                     <mat-icon>vpn_key</mat-icon>
                     <span>{{'ocpiendpoints.generate_new_token' | translate}}</span>
                   </button>
@@ -117,7 +117,7 @@
                   </div>
                 </div>
                 <div class="col-md-4 text-end">
-                  <button mat-raised-button color="primary" *ngIf="currentEndpoint.canPing" (click)="testConnection(formGroup.value)"
+                  <button mat-raised-button color="primary" *ngIf="(currentEndpoint | json) === '{}' || currentEndpoint.canPing" (click)="testConnection(formGroup.value)"
                     [disabled]="!token.value || baseUrl.errors?.required || baseUrl.errors?.pattern">
                     <mat-icon>touch_app</mat-icon>
                     <span>{{'ocpiendpoints.test_connection' | translate}}</span>

From 7f5648ffcf83a4d927f2e19f11b6307f01dab6e4 Mon Sep 17 00:00:00 2001
From: BANCHEREAU Caroline <caroline.banchereau@sap.com>
Date: Tue, 10 Jan 2023 14:07:11 +0100
Subject: [PATCH 2/4] added canPing + canGenerateLocalToken in ocpi auth

---
 .../endpoint/settings-ocpi-endpoint.component.html       | 4 ++--
 .../endpoint/settings-ocpi-endpoint.component.ts         | 8 ++++++--
 .../endpoint/settings-ocpi-endpoint.dialog.component.ts  | 9 +++++----
 .../settings-ocpi-endpoints-table-data-source.ts         | 9 +++++++--
 src/app/types/Authorization.ts                           | 2 ++
 5 files changed, 22 insertions(+), 10 deletions(-)

diff --git a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html
index 3e37375cd5..92b23c7549 100644
--- a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html
+++ b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html
@@ -98,7 +98,7 @@
                   </div>
                 </div>
                 <div class="col-md-4 text-end">
-                  <button mat-raised-button color="primary" *ngIf="(currentEndpoint | json) === '{}' || currentEndpoint.canGenerateLocalToken" (click)="generateLocalToken(formGroup.value)">
+                  <button mat-raised-button color="primary" *ngIf="((currentEndpoint | json) === '{}' && canGenerateLocalToken) || currentEndpoint.canGenerateLocalToken" (click)="generateLocalToken(formGroup.value)">
                     <mat-icon>vpn_key</mat-icon>
                     <span>{{'ocpiendpoints.generate_new_token' | translate}}</span>
                   </button>
@@ -117,7 +117,7 @@
                   </div>
                 </div>
                 <div class="col-md-4 text-end">
-                  <button mat-raised-button color="primary" *ngIf="(currentEndpoint | json) === '{}' || currentEndpoint.canPing" (click)="testConnection(formGroup.value)"
+                  <button mat-raised-button color="primary" *ngIf="((currentEndpoint | json) === '{}' && canPing) || currentEndpoint.canPing" (click)="testConnection(formGroup.value)"
                     [disabled]="!token.value || baseUrl.errors?.required || baseUrl.errors?.pattern">
                     <mat-icon>touch_app</mat-icon>
                     <span>{{'ocpiendpoints.test_connection' | translate}}</span>
diff --git a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.ts b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.ts
index 6e5d6ec086..ccead9d791 100644
--- a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.ts
+++ b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.ts
@@ -4,7 +4,7 @@ import { MatDialogRef } from '@angular/material/dialog';
 import { Router } from '@angular/router';
 import { TranslateService } from '@ngx-translate/core';
 import { StatusCodes } from 'http-status-codes';
-import { DialogMode } from 'types/Authorization';
+import { DialogMode, OcpiEndpointsAuthorizations } from 'types/Authorization';
 import { OCPIEndpoint } from 'types/ocpi/OCPIEndpoint';
 
 import { CentralServerService } from '../../../../../services/central-server.service';
@@ -24,6 +24,7 @@ export class SettingsOcpiEndpointComponent implements OnInit {
   @Input() public currentEndpoint!: OCPIEndpoint;
   @Input() public dialogRef!: MatDialogRef<any>;
   @Input() public dialogMode!: DialogMode;
+  @Input() public authorizations!: OcpiEndpointsAuthorizations;
 
   public formGroup!: FormGroup;
   public id!: AbstractControl;
@@ -37,7 +38,8 @@ export class SettingsOcpiEndpointComponent implements OnInit {
   public token!: AbstractControl;
   public isBackgroundPatchJobActive!: AbstractControl;
   public readOnly = true;
-
+  public canGenerateLocalToken: boolean;
+  public canPing: boolean;
 
   // eslint-disable-next-line no-useless-constructor
   public constructor(
@@ -97,6 +99,8 @@ export class SettingsOcpiEndpointComponent implements OnInit {
     this.localToken = this.formGroup.controls['localToken'];
     this.token = this.formGroup.controls['token'];
     this.isBackgroundPatchJobActive = this.formGroup.controls['backgroundPatchJob'];
+    this.canGenerateLocalToken = Utils.convertToBoolean(this.authorizations.canGenerateLocalToken);
+    this.canPing = Utils.convertToBoolean(this.authorizations.canPing);
     // Handle Dialog mode
     this.readOnly = this.dialogMode === DialogMode.VIEW;
     Utils.handleDialogMode(this.dialogMode, this.formGroup);
diff --git a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.dialog.component.ts b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.dialog.component.ts
index 18c99a2b08..da30a0e26d 100644
--- a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.dialog.component.ts
+++ b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.dialog.component.ts
@@ -1,25 +1,26 @@
 import { AfterViewInit, Component, Inject, ViewChild } from '@angular/core';
 import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
-import { DialogMode, DialogParams } from 'types/Authorization';
+import { DialogMode, DialogParams, DialogParamsWithAuth, OcpiEndpointsAuthorizations } from 'types/Authorization';
 
 import { OCPIEndpoint } from '../../../../../types/ocpi/OCPIEndpoint';
 import { Utils } from '../../../../../utils/Utils';
 import { SettingsOcpiEndpointComponent } from './settings-ocpi-endpoint.component';
 
 @Component({
-  template: '<app-ocpi-endpoint #appRef [currentEndpoint]="currentEndpoint" [dialogMode]="dialogMode" [dialogRef]="dialogRef"></app-ocpi-endpoint>',
+  template: '<app-ocpi-endpoint #appRef [currentEndpoint]="currentEndpoint" [dialogMode]="dialogMode" [dialogRef]="dialogRef" [authorizations]="authorizations"></app-ocpi-endpoint>',
 })
 export class SettingsOcpiEndpointDialogComponent implements AfterViewInit {
   @ViewChild('appRef') public appRef!: SettingsOcpiEndpointComponent;
   public currentEndpoint!: OCPIEndpoint;
   public dialogMode!: DialogMode;
-
+  public authorizations!: OcpiEndpointsAuthorizations;
 
   public constructor(
     public dialogRef: MatDialogRef<SettingsOcpiEndpointDialogComponent>,
-    @Inject(MAT_DIALOG_DATA) dialogParams: DialogParams<OCPIEndpoint>) {
+    @Inject(MAT_DIALOG_DATA) dialogParams: DialogParamsWithAuth<OCPIEndpoint, OcpiEndpointsAuthorizations>) {
     this.currentEndpoint = dialogParams.dialogData;
     this.dialogMode = dialogParams.dialogMode;
+    this.authorizations = dialogParams.authorizations;
   }
 
   public ngAfterViewInit() {
diff --git a/src/app/pages/settings-integration/ocpi/endpoints/settings-ocpi-endpoints-table-data-source.ts b/src/app/pages/settings-integration/ocpi/endpoints/settings-ocpi-endpoints-table-data-source.ts
index 97c43173c1..f90053f36a 100644
--- a/src/app/pages/settings-integration/ocpi/endpoints/settings-ocpi-endpoints-table-data-source.ts
+++ b/src/app/pages/settings-integration/ocpi/endpoints/settings-ocpi-endpoints-table-data-source.ts
@@ -61,7 +61,9 @@ export class SettingsOcpiEndpointsTableDataSource extends TableDataSource<OCPIEn
         next: (ocpiEndpoints) => {
           // Init auth
           this.authorizations = {
-            canCreate: Utils.convertToBoolean(ocpiEndpoints.canCreate)
+            canCreate: Utils.convertToBoolean(ocpiEndpoints.canCreate),
+            canGenerateLocalToken: Utils.convertToBoolean(ocpiEndpoints.canGenerateLocalToken),
+            canPing: Utils.convertToBoolean(ocpiEndpoints.canPing),
           };
           // Set visibility
           this.createAction.visible = this.authorizations.canCreate;
@@ -241,7 +243,10 @@ export class SettingsOcpiEndpointsTableDataSource extends TableDataSource<OCPIEn
     const dialogConfig = new MatDialogConfig();
     dialogConfig.minWidth = '50vw';
     dialogConfig.panelClass = 'transparent-dialog-container';
-    dialogConfig.data = { dialogData: endpoint, dialogMode };
+    dialogConfig.data = {
+      dialogData: endpoint,
+      dialogMode,
+      authorizations: this.authorizations };
     // disable outside click close
     dialogConfig.disableClose = true;
     // Open
diff --git a/src/app/types/Authorization.ts b/src/app/types/Authorization.ts
index 46e04efd8e..8629c25584 100644
--- a/src/app/types/Authorization.ts
+++ b/src/app/types/Authorization.ts
@@ -454,6 +454,8 @@ export interface OcpiEndpointsAuthorizations extends AuthorizationAttributes, Oc
 }
 
 export interface OcpiEndpointsAuthorizationActions extends DataResultAuthorizationActions {
+  canPing?: boolean;
+  canGenerateLocalToken?: boolean;
 }
 
 export interface OcpiEndpointAuthorizationActions extends AuthorizationActions {

From 7b0f0a87fa66da2bbaa94b722317179e13b0e7f2 Mon Sep 17 00:00:00 2001
From: BANCHEREAU Caroline <caroline.banchereau@sap.com>
Date: Tue, 10 Jan 2023 14:50:55 +0100
Subject: [PATCH 3/4] get rid of old verification now canGenerate and canPing
 are "global" no need to verify if there is currentEndpoint

---
 .../endpoints/endpoint/settings-ocpi-endpoint.component.html  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html
index 92b23c7549..627849e525 100644
--- a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html
+++ b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.html
@@ -98,7 +98,7 @@
                   </div>
                 </div>
                 <div class="col-md-4 text-end">
-                  <button mat-raised-button color="primary" *ngIf="((currentEndpoint | json) === '{}' && canGenerateLocalToken) || currentEndpoint.canGenerateLocalToken" (click)="generateLocalToken(formGroup.value)">
+                  <button mat-raised-button color="primary" *ngIf="canGenerateLocalToken" (click)="generateLocalToken(formGroup.value)">
                     <mat-icon>vpn_key</mat-icon>
                     <span>{{'ocpiendpoints.generate_new_token' | translate}}</span>
                   </button>
@@ -117,7 +117,7 @@
                   </div>
                 </div>
                 <div class="col-md-4 text-end">
-                  <button mat-raised-button color="primary" *ngIf="((currentEndpoint | json) === '{}' && canPing) || currentEndpoint.canPing" (click)="testConnection(formGroup.value)"
+                  <button mat-raised-button color="primary" *ngIf="canPing" (click)="testConnection(formGroup.value)"
                     [disabled]="!token.value || baseUrl.errors?.required || baseUrl.errors?.pattern">
                     <mat-icon>touch_app</mat-icon>
                     <span>{{'ocpiendpoints.test_connection' | translate}}</span>

From 01e6a8a88655c624ce85a7ca5943b484ab2bfe8a Mon Sep 17 00:00:00 2001
From: BANCHEREAU Caroline <caroline.banchereau@sap.com>
Date: Tue, 10 Jan 2023 14:52:51 +0100
Subject: [PATCH 4/4] updated imports

---
 .../endpoints/endpoint/settings-ocpi-endpoint.component.ts    | 4 ++--
 .../endpoint/settings-ocpi-endpoint.dialog.component.ts       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.ts b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.ts
index ccead9d791..5722ac5020 100644
--- a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.ts
+++ b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.component.ts
@@ -4,14 +4,14 @@ import { MatDialogRef } from '@angular/material/dialog';
 import { Router } from '@angular/router';
 import { TranslateService } from '@ngx-translate/core';
 import { StatusCodes } from 'http-status-codes';
-import { DialogMode, OcpiEndpointsAuthorizations } from 'types/Authorization';
-import { OCPIEndpoint } from 'types/ocpi/OCPIEndpoint';
 
 import { CentralServerService } from '../../../../../services/central-server.service';
 import { DialogService } from '../../../../../services/dialog.service';
 import { MessageService } from '../../../../../services/message.service';
 import { SpinnerService } from '../../../../../services/spinner.service';
+import { DialogMode, OcpiEndpointsAuthorizations } from '../../../../../types/Authorization';
 import { RestResponse } from '../../../../../types/GlobalType';
+import { OCPIEndpoint } from '../../../../../types/ocpi/OCPIEndpoint';
 import { Constants } from '../../../../../utils/Constants';
 import { Utils } from '../../../../../utils/Utils';
 
diff --git a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.dialog.component.ts b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.dialog.component.ts
index da30a0e26d..a786179b6f 100644
--- a/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.dialog.component.ts
+++ b/src/app/pages/settings-integration/ocpi/endpoints/endpoint/settings-ocpi-endpoint.dialog.component.ts
@@ -1,7 +1,7 @@
 import { AfterViewInit, Component, Inject, ViewChild } from '@angular/core';
 import { MAT_DIALOG_DATA, MatDialogRef } from '@angular/material/dialog';
-import { DialogMode, DialogParams, DialogParamsWithAuth, OcpiEndpointsAuthorizations } from 'types/Authorization';
 
+import { DialogMode, DialogParamsWithAuth, OcpiEndpointsAuthorizations } from '../../../../../types/Authorization';
 import { OCPIEndpoint } from '../../../../../types/ocpi/OCPIEndpoint';
 import { Utils } from '../../../../../utils/Utils';
 import { SettingsOcpiEndpointComponent } from './settings-ocpi-endpoint.component';