Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong hdbtabledata for Draft-enabled localized entities #66

Open
ghost opened this issue Apr 30, 2020 · 4 comments
Open

Wrong hdbtabledata for Draft-enabled localized entities #66

ghost opened this issue Apr 30, 2020 · 4 comments

Comments

@ghost
Copy link

ghost commented Apr 30, 2020

My deployments to HANA are failing for localized entities which are Fiori draft enabled.
For Fiori drafts, the compiler generates an additional key column for the _texts-tables (e.g.. ID_TEXT as UUID). This key column is not part of my csv-File (had no idea before that this column exist and what to put in there).

Deploying to SQLite works well. There, this key column gets filled automatically with a UUID.

Deploying to HANA fails however, because this artificial key is not considered at all.

Regards

@chgeo
Copy link

chgeo commented May 15, 2020

Hey Klaus :)

yes, I see where the issue is.. in order to avoid it, one must explicitly include the ID_TEXT column in the csv. This should work, right?
However, as you pointed out, this column is artificial and users maybe should not be concerned with it.
What about this idea: in the generated hdbtabledata, we could compute/infer ID_TEXT out of the given key values (Books.ID) and add it as constant value in the hdbtabledata file? Of course only if ID_TEXT is not in the csv.

@ghost
Copy link
Author

ghost commented May 15, 2020

Hi Christian,
Yes. I think this would meet user expectations that this "secret" column is automatically created for hdbtabledata the same way as it is generated for the database tables. But of course only in case of draft ;(.
Thanks and regards,

@chgeo
Copy link

chgeo commented May 15, 2020

What about this idea: in the generated hdbtabledata, we could compute/infer ID_TEXT out of the given key values (Books.ID) and add it as constant value in the hdbtabledata file?

Thinking about it, this can't be done within hdbtabledata, because you can only have a constant value for the whole column there, not for each record. So.. this leaves us with augmenting the csv file copy by the additional column...

@ghost
Copy link
Author

ghost commented May 15, 2020

It works fine for SQLite deployment. There, ID_texts gets populated with some generated UUIDs ...
Yes, it seems that this requires to not copy the orignal csv into gen/, but a modified one ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant