Skip to content
This repository has been archived by the owner on Nov 3, 2021. It is now read-only.

ExpConf without Spyder #1464

Open
stanislaw55 opened this issue Dec 22, 2020 · 1 comment · May be fixed by #1465
Open

ExpConf without Spyder #1464

stanislaw55 opened this issue Dec 22, 2020 · 1 comment · May be fixed by #1465
Labels
enhancement general general/transversal e.g. affecting more than one component, issues gui:sardanaeditor sardanaeditor related issues impact:medium size:S spock spock related issues

Comments

@stanislaw55
Copy link

Hi sardana community.
I tried to run expconf widget from Spock and bump into ImportError with spyder. After inspecting source code, it seems that spyder is only used to create actions in menu in sardana.taurus.qt.qtgui.extra_sardana.sardanaeditor.SardanaEditor.

Spyder is quite a big dependency (more than 120 indirect dependencies on PyPI) and installs lots of other tools (black, pylint, flake8, sphinx). On the other hand, current usage of spyder seems fairly simple. Would it be possible to somehow replace it with something lighter? Or maybe to make it weak, not hard, dependency?
@stanislaw55 stanislaw55 linked a pull request Dec 22, 2020 that will close this issue
Open
@reszelaz
Copy link
Collaborator

Hi @stanislaw55,

Thanks for reporting this! First of all, just to let you know that we are considering removing SardanaEditor from Sardana. In the Sardana users questionnaire we asked what is the interest in this widget which development was never finished. Soon we will get all the answers and will make a decission based on that.

BTW, how do you reproduce this issue? I tried it and I don't get the ImportError. What I get are the Taurus warnings:

zreszela@pc255:~/workspace/sardana (develop)> spock
MainThread     INFO     2021-01-15 13:38:57,725 TaurusRootLogger: Using PyQt5 (v5.7 with Qt 5.7.1 and Python 3.5.3)
MainThread     INFO     2021-01-15 13:38:58,017 TaurusRootLogger: Plugin "taurus_pyqtgraph" lazy-loaded as "taurus.qt.qtgui.tpg"
Spock 3.0.4-alpha -- An interactive laboratory application.

help      -> Spock's help system.
object?   -> Details about 'object'. ?object also works, ?? prints more.

IPython profile: spockdoor

Connected to Door_zreszela_1
/usr/lib/python3/dist-packages/h5py/__init__.py:34: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters

Door_zreszela_1 [1]: expconf
MainThread     WARNING  2021-01-15 13:39:00,768 TaurusRootLogger: Problem with taurus.qt.editor (hint: is spyder >=3 installed?)

Door_zreszela_1 [2]: MainThread     INFO     2021-01-15 13:39:01,856 TaurusRootLogger: Using PyQt5 (v5.7 with Qt 5.7.1 and Python 3.5.3)
MainThread     INFO     2021-01-15 13:39:02,117 TaurusRootLogger: Plugin "taurus_pyqtgraph" lazy-loaded as "taurus.qt.qtgui.tpg"
MainThread     WARNING  2021-01-15 13:39:02,153 TaurusRootLogger: <frozen importlib._bootstrap>:222: DeprecationWarning: taurus.core.util.d

/usr/lib/python3/dist-packages/h5py/__init__.py:34: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.flo.
  from ._conv import register_converters as _register_converters
MainThread     WARNING  2021-01-15 13:39:02,448 TaurusRootLogger: Problem with taurus.qt.editor (hint: is spyder >=3 installed?)
MainThread     INFO     2021-01-15 13:41:23,371 TaurusRootLogger: 
*********************
< Deprecation Counts (1):
        1 * "taurus.core.util.argparse is deprecated since 4.5.4. Use argparse or (better) click instead" >
Door_zreszela_1 [2]: 

Door_zreszela_1 [2]: import spyder
ImportError: No module named 'spyder'
(For more detailed information type: python_error)

@reszelaz reszelaz added the gui:sardanaeditor sardanaeditor related issues label Jan 29, 2021
@johanfforsberg johanfforsberg added enhancement spock spock related issues general general/transversal e.g. affecting more than one component, issues impact:medium size:S labels Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement general general/transversal e.g. affecting more than one component, issues gui:sardanaeditor sardanaeditor related issues impact:medium size:S spock spock related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/expconf without spyder synchrotron-solaris/sardana
3 participants
@johanfforsberg @reszelaz @stanislaw55