Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editable with markers cannot be handled correctly by Pipenv #16

Open
uranusjr opened this issue Aug 28, 2018 · 1 comment
Open

Editable with markers cannot be handled correctly by Pipenv #16

uranusjr opened this issue Aug 28, 2018 · 1 comment
Labels
question Further information is requested to do

Comments

@uranusjr
Copy link
Member

uranusjr commented Aug 28, 2018

This is probably not a problem of Passa, but only a TODO when we eventually integrate Passa into Pipenv.

The problem is that Pipenv passes the line directly to pip, so say if you have

"foo": {
    "editable": true,
    "markers": "os_name == 'nt'",
    "path": "."
}

This becomes -e .; os_name == 'nt', and Pipenv would run pip like this

pip install -e ".; os_name == 'nt'"

The solution is probably to drop the markers completely from the line. They are not needed since Pipenv already evaluates them before running the pip command anyway.

@techalchemy techalchemy added the question Further information is requested label Aug 31, 2018
@techalchemy
Copy link
Member

investigating why these aren't handled downstream, will update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested to do
Projects
None yet
Development

No branches or pull requests

2 participants