New disjoint method for provider #179
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This new method seems quite natrual, happy to take any bikeshedding suggestions. I have a hacky version of implementing it with pip and dep-logic: pypa/pip@main...notatallshaw:pip:speedy-resolve (For the real version I will need to more carefully consider when ExplicitRequirements and SpecifierRequirements are disjoint). But it already successfully speeds up various resolutions. |
1 task
|
I've come to realize a problem with this approach, or at least why pip couldn't easily adopt it, I write up in more detail shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #171
This allows the provider to implement a method to determine the causes which are disjoint, this has a number of advantages:
backtrack_causesinget_preferenceornarrow_requirement_selectionthey will be the disjoint causes allowing the provider to not have to iterate through as many causes or re-implement figuring out disjoint causes on every different method callResolutionImpossibleerrors the disjoint causes will naturally be returnedIf the provider does not implement a
disjointmethod then there is no behavior change, so this PR should be completely backwards compatible.