Implement sass --embedded in pure JS mode
#2413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntkme
force-pushed
the
embedded-compiler
branch
from
8d7d4de to
7084da7
Compare
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
e66df5b to
d53fcc5
Compare
4 tasks
ntkme
force-pushed
the
embedded-compiler
branch
9 times, most recently
from
d7e6206 to
b3794eb
Compare
ntkme
force-pushed
the
embedded-compiler
branch
3 times, most recently
from
9112b44 to
54fabf3
Compare
ntkme
force-pushed
the
embedded-compiler
branch
8 times, most recently
from
257b4fd to
ac718ee
Compare
ntkme
force-pushed
the
embedded-compiler
branch
from
d3c7314 to
1cb26f3
Compare
|
Ok, one more quirk for node worker. The way stdout/stderr stream in the worker thread works is that the worker posts message to the main thread and then the main thread writes the message asynchronously. So we cannot eagerly exit the main isolate, or otherwise the error message that the worker printed to stderr might get lost. |
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
5d9c449 to
2fff2e7
Compare
ntkme
force-pushed
the
embedded-compiler
branch
3 times, most recently
from
5233c41 to
7dc1e92
Compare
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
d0c8c1f to
5fa8f0d
Compare
ntkme
force-pushed
the
embedded-compiler
branch
3 times, most recently
from
1ebb5d1 to
2d1e04d
Compare
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
f0ea835 to
b19c6a8
Compare
ntkme
force-pushed
the
embedded-compiler
branch
from
b19c6a8 to
97d5c35
Compare
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
f6e6c4b to
1e8e188
Compare
ntkme
force-pushed
the
embedded-compiler
branch
3 times, most recently
from
7d10b08 to
6ef6075
Compare
ntkme
force-pushed
the
embedded-compiler
branch
2 times, most recently
from
77045ba to
37060c0
Compare
|
@nex3 I can see that the team is focusing most of the time on the postcss sass parser and this pull request has low priority. However, I would like to get this done in next few month before dart 3.8 become stable so that we can offer this as a replacement for dart ia32. Please take a look when you get a chance and let me know if you have any questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2325.
sass/embedded-host-node#344
Implementation
The actual isolate dispatcher and compilation dispatcher are nearly unchanged. However, I had to replace isolate with worker communication, and mock tons of small things that do not work on node.
Testing