Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TNC w/TCP connection - Integration #12

Open
rtubio opened this issue Nov 7, 2015 · 13 comments
Open

TNC w/TCP connection - Integration #12

rtubio opened this issue Nov 7, 2015 · 13 comments
Assignees

Comments

@rtubio
Copy link
Contributor

rtubio commented Nov 7, 2015

Task to handle the integration process with a TNC that can be accessed through a local TCP connection.

To do this, it is highly recommendable to go through the following steps:

  1. Implement a new command line argument so that the client can be executed with the following parameters:
python client_amp.py -g -u crespo -p cre.spo -t 2 -c tcp -i 127.0.0.1 -u 5001
  1. The UDP connection mode that is already implemented is a very good starting point for this issue. Find out how it is implemented along the code and try just to copy it and modify this new copy in order to implement the TCP connection.

  2. There are some automated tests that were created in order to implement the continuous integration process for the application. Maybe it is worth to take a look at them as well and try to implement the new test for the TCP conneciton.

@rohling
Copy link

rohling commented Nov 7, 2015

There are diagrams of the implementation of generic-client? t will be helpful in understanding the code ...

@rtubio
Copy link
Contributor Author

rtubio commented Nov 7, 2015

@sgongar : do you have any diagrams about the client?

@rohling
Copy link

rohling commented Nov 9, 2015

The TCP connection mode is implmented. But the UDP connection mode that is already implemented not is stable, and TCP connection mode this with the same problem .... during the call function "procressframe" from the object gsi.

Failure: exceptions.TypeError: unbound method _processframe() must be called with ClientProtocol instance as first argument (got GroundStationInterface instance instead)

@rtubio
Copy link
Contributor Author

rtubio commented Nov 9, 2015

@sgongar : can you give a hand on this to @rohling ?

@Jespindoladiaz
Copy link

The problem is this: The computer where the client is installed SATNET is different to where the TNC of ISIS, so it is important that the client listen on a variable IP address and a variable port, in this case the computer's IP ISIS: 161.24.19.170:7777

@sgongar
Copy link
Contributor

sgongar commented Nov 11, 2015

Actually some parts of the program are "patched" for initial tests and are working in local mode.
I will look if this point is good or not.

@rtubio
Copy link
Contributor Author

rtubio commented Nov 11, 2015

@sgongar : that should not be a problem, we should support both local and remote connections without the necessity of patching.... is there any issue that we are not aware of for this matter?

@rtubio
Copy link
Contributor Author

rtubio commented Nov 12, 2015

@rohling : how are you doing with this issue? Do you need any help?

@rohling
Copy link

rohling commented Nov 12, 2015

@rtp-calpoly : already implemented and merged the pull request: bd51211

@rtubio
Copy link
Contributor Author

rtubio commented Nov 12, 2015

@rohling : ok, perfect! Have you tried using it with the real TCP connection with the ISIS software?

@rohling
Copy link

rohling commented Nov 12, 2015

@rtp-calpoly: As I wrote above: the UDP connection mode that is already implemented not is stable, and TCP connection mode this with the same problem .... during the call function "procressframe" from the object gsi.
Failure: exceptions.TypeError: unbound method _processframe() must be called with ClientProtocol instance as first argument (got GroundStationInterface instance instead)

I get an error when I create a socket client and forward a frame for the generic-client.(UDP/TCP)

@rtubio
Copy link
Contributor Author

rtubio commented Nov 12, 2015

@sgongar : can you take a look at this?

@rtubio
Copy link
Contributor Author

rtubio commented Nov 12, 2015

@rohling : working on your branch for this TCP implementation, can you try to fix the bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants