Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: allow 3rd code called by martian log lines with request trace ID #544

Open
mmatczuk opened this issue Nov 17, 2023 · 2 comments
Open

log: allow 3rd code called by martian log lines with request trace ID #544

mmatczuk opened this issue Nov 17, 2023 · 2 comments
Labels
log
Milestone
v1.5

Comments

@mmatczuk
Copy link
Contributor

Logging of request trace ID should be moved to the forwarder/log package to enable logging trace ID from other code paths.
@mmatczuk mmatczuk added this to the v1.2 milestone Nov 17, 2023
@mmatczuk
Copy link
Contributor Author

mmatczuk commented Feb 9, 2024

This requires logger API change to accept context.

@mmatczuk mmatczuk modified the milestones: v1.2, v1.3 Feb 9, 2024
mmatczuk added a commit that referenced this issue Feb 9, 2024
@mmatczuk
martian: add TraceID aware logger wrapper
180dac0 
Move trace ID logging logic close to traceID.
Use logger stacking to add features to logs.

This is only temporary and traceID should be moved to the toplevel log package.
To make it work we would need to change the main Logger interface, see #544.
mmatczuk added a commit that referenced this issue Feb 12, 2024
@mmatczuk
martian: add TraceID aware logger wrapper
ce9225d 
Move trace ID logging logic close to traceID.
Use logger stacking to add features to logs.

This is only temporary and traceID should be moved to the toplevel log package.
To make it work we would need to change the main Logger interface, see #544.
@Choraden Choraden modified the milestones: v1.3, v1.4 Apr 15, 2024
@mmatczuk
Copy link
Contributor Author

Relates to #352

@mmatczuk mmatczuk added the log label Sep 12, 2024
@mmatczuk mmatczuk modified the milestones: v1.4, v1.5 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
log
Projects
None yet
Milestone
v1.5
Development

No branches or pull requests
2 participants
@mmatczuk @Choraden