Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ci #127

Merged
merged 3 commits into from
Jun 20, 2024
Merged

Better ci #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c309de8
Use `npm ci` and build app on PRs
ebekebe Jun 20, 2024
039a8be
deploy on main
ebekebe Jun 20, 2024
9c4324d
Use same CI env var setting for PR pipeline and deployment
ebekebe Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/github-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: github pages release

on: workflow_dispatch
# push:
# branches:
# - main
on:
push:
branches:
- main
# paths:
# - '.storybook'
# - 'public'
Expand All @@ -28,7 +28,7 @@ jobs:
CI: false
run: |
ls
npm install
npm ci
npm run build

- name: Build storybook
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/sample-app-web.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ jobs:

# Site Testing steps
- name: Install dependencies
run: npm install
run: npm ci

- name: Build
run: CI=false npm run build

- name: Run Unit Tests and generate coverage report
run: npm run test.coverage
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ ENV PATH="$HOME/sc-4.8.2-linux/bin:$PATH"
# web app
WORKDIR /sample-app-web
COPY . .
RUN npm install
RUN npm ci
Loading