Sauce Visual Baseline Overrides #3022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview ready for 3022! |
omacranger
force-pushed
the
feat/visual-baseline-overrides
branch
from
1ad7ad8 to
029648c
Compare
|
Deploy preview ready for 3022! |
konraddysput
approved these changes
Nov 27, 2024
| client.create_snapshot_from_webdriver( | ||
| name="Snapshot Name", | ||
| session_id=session_id, | ||
| driver=driver, # pass the remote driver instance from selenium/appium |
There was a problem hiding this comment.
double checking: is this change expected?
There was a problem hiding this comment.
yes, the python sdk was updated a while back to use a driver instead of a session ID to expose job information for native mobile
omacranger
force-pushed
the
feat/visual-baseline-overrides
branch
from
029648c to
8e069a1
Compare
|
Deploy preview ready for 3022! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of Changes