Skip to content

Commit 816c94e

Browse files
Don't create the same release twice (#17)
1 parent ec8e5f2 commit 816c94e

File tree

3 files changed

+26
-26
lines changed

3 files changed

+26
-26
lines changed

.github/workflows/bindist-full.yml

+5-13
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ on:
66
release-version:
77
required: true
88
type: string
9+
upload-url:
10+
required: true
11+
type: string
912

1013
jobs:
1114
dist:
@@ -62,25 +65,14 @@ jobs:
6265
if-no-files-found: error
6366
retention-days: 1
6467

65-
- id: create_release
66-
if: ${{ github.ref_type == 'tag' }}
67-
uses: actions/create-release@v1
68-
env:
69-
GITHUB_TOKEN: ${{ github.token }}
70-
with:
71-
tag_name: ${{ github.ref }}
72-
release_name: v${{ inputs.release-version }}
73-
draft: false
74-
prerelease: false
75-
7668
- name: Upload release asset (${{ steps.filenames.outputs.diktat-cli-tgz }})
7769
id: upload-release-asset-tgz
7870
if: ${{ github.ref_type == 'tag' }}
7971
uses: actions/upload-release-asset@v1
8072
env:
8173
GITHUB_TOKEN: ${{ github.token }}
8274
with:
83-
upload_url: ${{ steps.create_release.outputs.upload_url }}
75+
upload_url: ${{ inputs.upload-url }}
8476
asset_path: ${{ steps.filenames.outputs.diktat-cli-tgz }}
8577
asset_name: ${{ steps.filenames.outputs.diktat-cli-tgz }}
8678
asset_content_type: application/gzip
@@ -92,7 +84,7 @@ jobs:
9284
env:
9385
GITHUB_TOKEN: ${{ github.token }}
9486
with:
95-
upload_url: ${{ steps.create_release.outputs.upload_url }}
87+
upload_url: ${{ inputs.upload-url }}
9688
asset_path: ${{ steps.filenames.outputs.diktat-cli-zip }}
9789
asset_name: ${{ steps.filenames.outputs.diktat-cli-zip }}
9890
asset_content_type: application/zip

.github/workflows/bindist-thin.yml

+5-13
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ on:
66
release-version:
77
required: true
88
type: string
9+
upload-url:
10+
required: true
11+
type: string
912

1013
jobs:
1114
dist:
@@ -50,25 +53,14 @@ jobs:
5053
if-no-files-found: error
5154
retention-days: 1
5255

53-
- id: create_release
54-
if: ${{ github.ref_type == 'tag' }}
55-
uses: actions/create-release@v1
56-
env:
57-
GITHUB_TOKEN: ${{ github.token }}
58-
with:
59-
tag_name: ${{ github.ref }}
60-
release_name: v${{ inputs.release-version }}
61-
draft: false
62-
prerelease: false
63-
6456
- name: Upload release asset (${{ steps.filenames.outputs.diktat-cli-tgz }})
6557
id: upload-release-asset-tgz
6658
if: ${{ github.ref_type == 'tag' }}
6759
uses: actions/upload-release-asset@v1
6860
env:
6961
GITHUB_TOKEN: ${{ github.token }}
7062
with:
71-
upload_url: ${{ steps.create_release.outputs.upload_url }}
63+
upload_url: ${{ inputs.upload-url }}
7264
asset_path: ${{ steps.filenames.outputs.diktat-cli-tgz }}
7365
asset_name: ${{ steps.filenames.outputs.diktat-cli-tgz }}
7466
asset_content_type: application/gzip
@@ -80,7 +72,7 @@ jobs:
8072
env:
8173
GITHUB_TOKEN: ${{ github.token }}
8274
with:
83-
upload_url: ${{ steps.create_release.outputs.upload_url }}
75+
upload_url: ${{ inputs.upload-url }}
8476
asset_path: ${{ steps.filenames.outputs.diktat-cli-zip }}
8577
asset_name: ${{ steps.filenames.outputs.diktat-cli-zip }}
8678
asset_content_type: application/zip

.github/workflows/release.yml

+16
Original file line numberDiff line numberDiff line change
@@ -37,15 +37,30 @@ jobs:
3737
3838
echo "release-version=${RELEASE_VERSION}" >>"${GITHUB_OUTPUT}"
3939
shell: bash
40+
41+
- id: release
42+
name: Create the release
43+
if: ${{ github.ref_type == 'tag' }}
44+
uses: actions/create-release@v1
45+
env:
46+
GITHUB_TOKEN: ${{ github.token }}
47+
with:
48+
tag_name: ${{ github.ref }}
49+
release_name: v${{ steps.version.outputs.release-version }}
50+
draft: false
51+
prerelease: false
52+
4053
outputs:
4154
release-version: ${{ steps.version.outputs.release-version }}
55+
upload-url: ${{ steps.release.outputs.upload_url }}
4256

4357
bindist-thin:
4458
name: Binary distribution (thin)
4559
needs: [ version ]
4660
uses: ./.github/workflows/bindist-thin.yml
4761
with:
4862
release-version: ${{ needs.version.outputs.release-version }}
63+
upload-url: ${{ needs.version.outputs.upload-url }}
4964
secrets: inherit
5065

5166
bindist-full:
@@ -54,6 +69,7 @@ jobs:
5469
uses: ./.github/workflows/bindist-full.yml
5570
with:
5671
release-version: ${{ needs.version.outputs.release-version }}
72+
upload-url: ${{ needs.version.outputs.upload-url }}
5773
secrets: inherit
5874

5975
move-tag:

0 commit comments

Comments
 (0)