New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML handling javascript on wrong place #217

Open

eilst opened this issue Nov 22, 2018 · 0 comments

Assignees

Contributor

eilst commented Nov 22, 2018

Is your feature request related to a problem? Please describe.
https://github.com/savoirfairelinux/project-addons/pull/215/files#r235826685
SAML error messages should be in English by default. And we need to move it to the SAML module, not here.

Describe the solution you'd like
Propose a PR to the SAML OCA module, remove it from here because this module has nothing to do with SAML.

Describe alternatives you've considered
Put the SAML on gitlab on the web module, but better to go with the PR to the SAML OCA module.

Additional context
https://github.com/savoirfairelinux/project-addons/pull/215/files#r235826685

eilst assigned lgharib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment