Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS1_3_VERSION needs to be ifdef'ed #70

Closed
lindig opened this issue Feb 16, 2021 · 3 comments
Closed

TLS1_3_VERSION needs to be ifdef'ed #70

lindig opened this issue Feb 16, 2021 · 3 comments

Comments

@lindig
Copy link

lindig commented Feb 16, 2021

Compilation of HEAD fails on openssl releases that don't define TLS1_3_VERSION. The code is in general careful by using HAVE_TLS13 et al to avoid this but this is not the case in

A quick fix is in

but a more systematic approach would be beneficial.

@dinosaure
Copy link

I can confirm a compilation error on alpine-3.13 with OCaml 4.12.

@craigfe
Copy link

craigfe commented May 21, 2021

This issue is still failing some of our CI running on alpine-3.13.

Is it possible to cherry-pick 5cbeba7 from #63 and merge that as a separate change?

@psafont
Copy link
Contributor

psafont commented Nov 12, 2021

Fixed by #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants