Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is issue in Savon with empty nodes filled with attributes in hash #27

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Pepan
Copy link

@Pepan Pepan commented Nov 23, 2012

Issue: savonrb/savon#314

Problem: When node is empty, it leaves it as hash and fills it with attributes. This is wrong.
I commented line out...

@rubiii
Copy link
Contributor

rubiii commented Dec 12, 2012

can you add specs to describe your problem and verify the fix?

@kPhilosopher
Copy link

Did you get a chance to do the specs?

@Pepan
Copy link
Author

Pepan commented Apr 23, 2013

Not jet. Too bussy.

Psáno z telefonu.
Dne 23.4.2013 0:32 "kPhilosopher" [email protected] napsal(a):

Did you get a chance to do the specs?


Reply to this email directly or view it on GitHubhttps://github.com//pull/27#issuecomment-16828227
.

@formigarafa
Copy link

I don't know for sure, but maybe if you just pass delete_namespace_attributes => true to Parser initializer you will get the expected response with blanks instead of namespece attributes.

@lholden
Copy link

lholden commented Mar 27, 2020

I'm finding this to be an issue for me too.

The attributes of any self closing tag <sometag attribute="bla" /> are being provided as the value after conversion to a hash.

Setting delete_namespace_attributes to true fixes the problem for me... but it was pretty surprising to encounter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants