Improved typecasting and XML namespace prefix detection. #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cleanup up recursive hash generation logic (split into several shorter methods) * moved type casting logic into separate classes
…to README. * Added spec for custom type conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @rubiii,
I currently have to implement a SOAP web service for rails (using wash_out).
I tested the services using savon and my specs keep failing because nori's
typecasting doesn't work properly (namespace prefix in nori is hard-coded).
So I decided to refactor nori. So far I've added:
Pls have a look at the updated README
What do you think about it?
Can you include it in the next release of nori?
Cheers,
Ruben