fix 'undefined method for nil:NilClass' on wrong xmls #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderZagaynov
force-pushed
the
incorrect_xml_fix
branch
from
58c5f35
to
f1b9a60
Compare
AlexanderZagaynov
force-pushed
the
incorrect_xml_fix
branch
from
f1b9a60
to
75deb6e
Compare
|
Thanks for your patience. Is this still relevant? I just tried your test case against main and it doesn't fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78
#64 introduced a confusing error "undefined method" on malformed xmls.
This change reraise this error with the proper class and message.