chore: upgrade nodejs version #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
say8425
approved these changes
Mar 22, 2024
coquer
force-pushed
the
master
branch
3 times, most recently
from
c864965
to
3297181
Compare
|
@say8425 I will have a look at test-github-actions later, don't know why is failing. |
|
Looks the test was failed. This gh action has a test that really request getting a AWS secret manager key-value. Test log says getting a value is nothing. |
|
Will have a look to see what is going on. |
say8425
reviewed
Apr 14, 2024
| @@ -3,7 +3,6 @@ const aws = require('aws-sdk') | |||
| const fs = require('fs') | |||
|
|
|||
| const outputPath = core.getInput('OUTPUT_PATH') | |||
| const secretName = core.getInput('SECRET_NAME') | |||
There was a problem hiding this comment.
I think secretName was removed make this action failed. How about recover it?
There was a problem hiding this comment.
Looks like that. We will have a look at it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade nodejs version to 20. Closes #131