Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring: standardize hyphens and break-word usage #3158

Open
jeripeierSBB opened this issue Oct 17, 2024 · 0 comments
Open

refactoring: standardize hyphens and break-word usage #3158

jeripeierSBB opened this issue Oct 17, 2024 · 0 comments
Labels
proposal: open
Milestone
Release 2.0.0

Comments

@jeripeierSBB
Copy link
Contributor

jeripeierSBB commented Oct 17, 2024 •
edited
Loading

In some components we use hyphens and in some we use break-word. Please adapt as follows with a breaking change:

  • keep hyphens (navigation, teaser-hero)
  • remove break-word in the link (check outcome in link-list/ footer)
  • remove break-word from sbb-dialog and add hyphens: auto to dialog title only.
@jeripeierSBB jeripeierSBB added the type: bug 🐛 Something isn't working label Oct 17, 2024
@jeripeierSBB jeripeierSBB added this to the Release 2.0.0 milestone Oct 17, 2024
@jeripeierSBB jeripeierSBB moved this from Funnel to To do in ESTA Web Lyne Design System Oct 17, 2024
@jeripeierSBB jeripeierSBB added proposal: open and removed type: bug 🐛 Something isn't working labels Oct 17, 2024
@jeripeierSBB jeripeierSBB moved this from To do to Next in ESTA Web Lyne Design System Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
proposal: open
Projects
ESTA Web Lyne Design System
Status: Next
Milestone
Release 2.0.0
Development

No branches or pull requests
1 participant
@jeripeierSBB