feat: Добавлено событие everything, срабатывающее при любом событии #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evgeniysemin, в задаче имелось ввиду, подписаться на сообщения для канваса ( |
sasha-tlt
reviewed
Nov 2, 2021
| const observables = new Map<string, { next: ObserverFunc<A | AssistantSmartAppError>; requestId?: string }>(); | ||
| const { on, emit } = createNanoEvents<AssistantEvents<A> & EverythingEvent<A>>(); | ||
| const emitCommand = (command: AssistantClientCustomizedCommand<A>) => { |
There was a problem hiding this comment.
emitCommand не случится, если есть подписка на ответ - эмитить everything нужно в любом случае
https://github.com/sberdevices/assistant-client/pull/217/files#diff-4a8e2af747f7708c3f686add51592371c9d7ffd3a905ff4b25fcfa1859e31e10L209
evgeniysemin
force-pushed
the
issues/214
branch
from
ab3c83a
to
737e8ee
Compare
evgeniysemin
force-pushed
the
issues/214
branch
from
737e8ee
to
d65518f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
4.10.0--canary.217.61c59d5c905a6880310bdb4dc3ea35f85766a342.0✨ Test out this PR locally via:
npm install @sberdevices/assistant-client@4.10.0--canary.217.61c59d5c905a6880310bdb4dc3ea35f85766a342.0 # or yarn add @sberdevices/assistant-client@4.10.0--canary.217.61c59d5c905a6880310bdb4dc3ea35f85766a342.0