Merge pull request #129 from sbidoul/test-py312

Test with python 3.12

Author: sbidoul

.github/workflows/ci.yml

@@ -30,7 +30,7 @@ jobs:
             python-version: "3.8"
             python: python
           - os: "windows-latest"
-            python-version: "3.11"
+            python-version: "3.12"
             python: python
           # macos
           - os: "macos-latest"
@@ -43,7 +43,7 @@ jobs:
             python-version: "3.8"
             python: python
           - os: "macos-latest"
-            python-version: "3.11"
+            python-version: "3.12"
             python: python
           # ubuntu
           - os: ubuntu-20.04
@@ -67,6 +67,9 @@ jobs:
           - os: ubuntu-latest
             python-version: "3.11"
             python: python
+          - os: ubuntu-latest
+            python-version: "3.12"
+            python: python
     steps:
       - uses: "actions/checkout@v3"
       - uses: "actions/setup-python@v4"

pyproject.toml

@@ -22,6 +22,7 @@ classifiers = [
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
+    "Programming Language :: Python :: 3.12",
 ]
 requires-python = ">=3.8"
 dependencies=[

tests/conftest.py

@@ -8,7 +8,7 @@
 
 
 @pytest.fixture
-def virtualenv_python(tmp_path):
+def virtualenv_python(tmp_path, testpkgs):
     """Return a python executable path within an isolated virtualenv, using a pip
     version that has the new resolver."""
     venv = tmp_path / "venv"
@@ -18,7 +18,21 @@ def virtualenv_python(tmp_path):
     else:
         python = venv / "bin" / "python"
     # use latest pip
-    subprocess.check_call([str(python), "-m", "pip", "install", "-U", "pip"])
+    subprocess.check_call(
+        [
+            str(python),
+            "-m",
+            "pip",
+            "install",
+            "--no-index",
+            "--find-links",
+            testpkgs,
+            "-U",
+            "pip",
+            "setuptools",
+            "wheel",
+        ]
+    )
     return str(python)
 
 
@@ -70,6 +84,20 @@ def testpkgs(tmp_path_factory):
 
     testpkgs_dir = tmp_path_factory.mktemp("testpkgs")
 
+    # Download some wheels so we can build pyproject-based packages without network.
+    subprocess.check_call(
+        [
+            sys.executable,
+            "-m",
+            "pip",
+            "wheel",
+            "setuptools",
+            "wheel",
+            "--wheel-dir",
+            str(testpkgs_dir),
+        ]
+    )
+
     for testpkg_kw in testpkgs_kw:
         setup_py_dir = tmp_path_factory.mktemp("testpkg")
         (setup_py_dir / "setup.py").write_text(
@@ -82,26 +110,14 @@ def testpkgs(tmp_path_factory):
                 "-m",
                 "pip",
                 "wheel",
-                "--no-build-isolation",
+                "--no-index",
+                "--find-links",
+                str(testpkgs_dir),
                 "--no-deps",
                 str(setup_py_dir),
                 "--wheel-dir",
                 str(testpkgs_dir),
             ],
         )
 
-    # Download some wheels so we can build pyproject-based packages without network.
-    subprocess.check_call(
-        [
-            sys.executable,
-            "-m",
-            "pip",
-            "wheel",
-            "setuptools",
-            "wheel",
-            "--wheel-dir",
-            str(testpkgs_dir),
-        ]
-    )
-
     return testpkgs_dir.as_uri()

tests/test_pip_list_json.py

@@ -55,6 +55,10 @@
         )
     ],
 )
+@pytest.mark.skipif(
+    sys.version_info >= (3, 12),
+    reason="pip-list-json.py not used in python 3.12+",
+)
 def test_pip_list_json(
     to_install, expected, virtualenv_python_with_pytest_cov, testpkgs
 ):

tests/test_sanity.py

@@ -31,6 +31,10 @@ def test_sanity_pip_version(virtualenv_python, capsys):
     assert "works best with pip>=20.1" in captured.err
 
 
+@pytest.mark.skipif(
+    sys.version_info >= (3, 12),
+    reason="All pip versions that support Python 3.12 have pip inspect",
+)
 def test_sanity_pkg_resources(virtualenv_python, capsys):
     assert check_env(virtualenv_python)
     subprocess.check_call([virtualenv_python, "-m", "pip", "install", "-q", "pip<22.2"])
@@ -43,11 +47,19 @@ def test_sanity_pkg_resources(virtualenv_python, capsys):
     assert "pkg_resources is not available" in captured.err
 
 
+@pytest.mark.skipif(
+    sys.version_info >= (3, 12),
+    reason=(
+        "All pip versions that support Python 3.12 have do not do setup.py install "
+        "so checking for the presence of wheel is not required."
+    ),
+)
 def test_sanity_wheel(virtualenv_python, capsys):
     assert check_env(virtualenv_python)
     subprocess.check_call([virtualenv_python, "-m", "pip", "install", "-q", "pip<23.1"])
     subprocess.check_call([virtualenv_python, "-m", "pip", "uninstall", "-qy", "wheel"])
-    # wheel is not strictly required, although pip works better with it
+    # wheel is not strictly required, although older pip versions did work better with
+    # it. Recent pip versions do not use setup.py install so wheel is not required.
     assert check_env(virtualenv_python)
     captured = capsys.readouterr()
     assert "wheel is not available" in captured.err

tox.ini

@@ -1,5 +1,5 @@
 [tox]
-envlist = py27,py36,py37,py38,py39,py310,py311,mypy,twine_check
+envlist = py27,py36,py37,py38,py39,py310,py311,py312,mypy,twine_check
 isolated_build = true
 
 [gh-actions]
@@ -10,7 +10,8 @@ python =
   3.8: py38,mypy
   3.9: py39,mypy
   3.10: py310,mypy
-  3.11: py311,mypy,twine_check
+  3.11: py311,mypy
+  3.12: py312,mypy,twine_check
 
 [testenv]
 extras = test