Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 support #46

Open
robert-scheck opened this issue Sep 10, 2018 · 7 comments
Open

Python 3 support #46

robert-scheck opened this issue Sep 10, 2018 · 7 comments
Assignees

Comments

@robert-scheck
Copy link
Contributor

When looking to https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3, I feel we should start to test MacroMilter using Python 3 in the future. Python 3.4 is also available via EPEL 7, including PyMilter. This does not mean that I am proposing to break Python 2.7 compatibility in MacroMilter though.

@sbidy sbidy self-assigned this Sep 13, 2018
@robert-scheck
Copy link
Contributor Author

https://fedoraproject.org/wiki/Changes/F31_Mass_Python_2_Package_Removal will sooner or later lead to MacroMilter removal in Fedora due to Python 2.x dependencies, given Python 2.x reaches finally EOL on 2020-01-01.

@robert-scheck robert-scheck changed the title Python 3 tests Python 3 support Aug 14, 2019
@robert-scheck
Copy link
Contributor Author

As per https://bugzilla.redhat.com/show_bug.cgi?id=1738083, the Python 3 support starts to get important. I'm currently investigating to ensure proper Python 3.6 (or later) dependencies on all relevant branches to avoid the needs to have Python 2 support here and Python 3 support there.

@sbidy
Copy link
Owner

sbidy commented Aug 14, 2019

I covered and tested the Py3 comp. in the 3.7 branch. Actual there is an issue with the io.BytesIO and io.StringIO (which is a new implementation in py3). I'm working on that - in general the code is Python 3.6+ compatible.

@robert-scheck
Copy link
Contributor Author

robert-scheck commented Aug 14, 2019

Thank you. Please let me know when there is something that has pre-release quality. Python 3.6 is the available Python in RHEL/CentOS 7.7 and 8.0 (and later), Fedora has Python 3.7.

@robert-scheck
Copy link
Contributor Author

Do you have some status update? Will there be a MacroMilter version supporting Python 3.6+ until mid-November?

@sbidy
Copy link
Owner

sbidy commented Nov 7, 2019

Still in testing. I'm looking forward to release the 3.7 for Py3 in Nov. / early Dec..
I have to check the functionality with "real world" mail traffic but my current test system was "unavailable".

@robert-scheck
Copy link
Contributor Author

I covered and tested the Py3 comp. in the 3.7 branch. Actual there is an issue with the io.BytesIO and io.StringIO (which is a new implementation in py3). I'm working on that - in general the code is Python 3.6+ compatible.

Not sure if I get the issue properly, but oletools/mraptor_milter.py seems to support Python 3 meanwhile, did you have a look there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants