Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3 compatibility broken for ToJson #191

Open
crispywalrus opened this issue Jan 23, 2023 · 2 comments
Open

Scala 3 compatibility broken for ToJson #191

crispywalrus opened this issue Jan 23, 2023 · 2 comments

Comments

@crispywalrus
Copy link

BuildInfoOption.ToJson generates code that doesn't compile with scala 3.x. It uses _ wildcards and tries to match against scala.Int (and many other types) These have been changed in scala 3 so perhaps we need a option or fork that produces scala 3 compatible code.

@arixmkii
Copy link
Contributor

arixmkii commented Feb 2, 2023

No need to fork. It could be added with Scala3 renderers and then users could opt in to use this renderers, when they need Scala3 code. I never tried using generated sources for multiple Scala version, so, I don't know if it is possible to just generate for both Scala2 and Scala3 at the same time (w/o requiring additional support from SBT).

@rreckel
Copy link
Contributor

rreckel commented Aug 4, 2023

Hi,

I just opened a pull request that should solve this issue.
Hope it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants