Fix infinite recursion with Compile packageBin #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, so this PR is causing |
|
So for This looks like I will have to go back to the drawing board, possible even abandoning #103 and using another solution (such as |
|
Commented on the issue - #104 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #104
Pinging @romainreuillon since #79 (comment) was the cause of the regression. @romainreuillon Can you confirm that this PR still solves the asynchronicity issue with package task?
@eed3si9n Since you know the sbt internals if you have time maybe you can comment on this (since at #79 (comment) you did mention that doing this can cause issues). See the linked issue for more info