Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to assign key/value properties to trees, nodes and segments #7483

Open
philippotto opened this issue Dec 6, 2023 · 1 comment · May be fixed by #7875
Open

Allow to assign key/value properties to trees, nodes and segments #7483

philippotto opened this issue Dec 6, 2023 · 1 comment · May be fixed by #7875

Comments

@philippotto
Copy link
Member

philippotto commented Dec 6, 2023

Detailed Description

Custom properties (key-value pairs) can be useful as metadata for skeleton trees, nodes and segments. As a first iteration, we should implement this for segments. Afterwards, for trees and then later maybe for nodes, too.

  • keys should be arbitrary (but suggesting keys that were used somewhere else would be cool)
  • key-values for one object are expected to be not that many (< 20 ?). sending all key-values for one object when updating them should be okay.
  • an index for faster querying is not necessary for now (can be added later)
  • tags should be versioned like the rest of the annotation
  • UI:
    • an object that has assigned tags should have a tag icon in its list
    • for editing tags, the first iteration could look somewhat like in the screenshot below. antd tags next to each other might be nice, too, though (could be in key=value format)
    • by default, the tag UI should not swallow huge real estate
    • the active object (e.g., the active segment) could display its tags

image

  • NML: maybe something like <property name="myPropertyName" value="x"> inside of the <segment> tag?

Context

https://scm.slack.com/archives/C5AKLAV0B/p1701863377470609

It might make sense to separately maintain a flat list of all used keys, so that autocomplete/dropdown can be offered

@philippotto philippotto changed the title Allow to assign key/value properties to skeletons and their nodes Allow to assign key/value properties to trees, nodes and segments Feb 6, 2024
@philippotto philippotto self-assigned this Feb 6, 2024
@philippotto philippotto removed their assignment Mar 5, 2024
@philippotto
Copy link
Member Author

@fm3 @normanrz I tried to jot down the details of what we discussed. feel free to extend the description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants