fixup deployment

Author: williamlardier

.github/workflows/end2end.yaml

@@ -653,7 +653,7 @@ jobs:
           GCP_SECRET_KEY: ${{ secrets.AWS_GCP_BACKEND_SECRET_KEY }}
         run: |
           if [[ "${{ env.ENABLE_RING_TESTS }}" == "true" ]]; then
-            ./setup-tests.sh --kubeconfig ~/.kube/config -- setup --metadata
+            ./setup-tests.sh --kubeconfig ~/.kube/config
           else
             ./setup-tests.sh --kubeconfig ~/.kube/config -- setup --rbac --dns --buckets --locations --accounts --endpoints --workflows --tls
           fi

tests/@setup/src/cli.ts

@@ -273,20 +273,12 @@ async function runSetup(options: any) {
         }
 
         if (options.metadata) {
-            if (!setupFlags.rbac) {
-                tasks.push({
-                    name: 'RBAC', fn: async () => {
-                        await setupRBAC({
-                            namespace: options.namespace || 'default',
-                        });
-                        setupFlags.rbac = true;
-                        logger.debug('RBAC setup flag set (auto-enabled for metadata)');
-                    }
-                });
-            }
-            
             tasks.push({
                 name: 'Metadata Service', fn: () => {
+                    if (!setupFlags.rbac) {
+                        throw new Error('RBAC setup is required before metadata setup');
+                    }
+                    
                     return setupMetadata({
                         gitAccessToken: options.gitAccessToken || process.env.GIT_ACCESS_TOKEN,
                         namespace: options.metadataNamespace || 'metadata',