MK8S-25: Fix nginx container health check failures by creating index files before container start

The nginx container was failing health checks because index.html files were being
created AFTER the container started, causing 403 "directory index forbidden" errors
during the liveness/readiness probes.

This fix moves the index.html file creation to happen BEFORE the container manifest
is deployed, ensuring the files exist when nginx starts and can serve the health
check requests successfully.

Root cause: nginx.conf has "autoindex off; index index.html;" but files didn't exist
at container startup time, causing health check failures and container restarts.

Author: rdebay-scality

salt/metalk8s/repo/installed.sls

@@ -73,6 +73,7 @@ Install repositories manifest:
       - file: Generate repositories nginx configuration
       - file: Deploy container registry nginx configuration
       - file: Generate container registry configuration
+      - file: Create saltenv index file
 
 Delay after repositories pod deployment:
   module.wait:
@@ -94,7 +95,6 @@ Ensure repositories container is up:
       - metalk8s: Install repositories manifest
     - require:
       - module: Delay after repositories pod deployment
-      - file: Create saltenv index file
 
 # Create index.html files to prevent directory listing issues
 Create repository index files:
@@ -103,8 +103,6 @@ Create repository index files:
     - contents: ''
     - makedirs: True
     - mode: 644
-    - require:
-      - module: Ensure repositories container is up
 
 Create saltenv index file:
   file.managed:
@@ -121,3 +119,5 @@ Wait for Repositories container to answer:
      repo.port }}/{{ saltenv }}/
    - status: 200
    - request_interval: 1
+   require:
+      - file: Create saltenv index file