Skip to content

Commit 5bc393e

Browse files
committed
Merge branch 'master' into develop
# Conflicts: # src/settings.ts
2 parents 6e62df2 + 58cc640 commit 5bc393e

8 files changed

+73
-7
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ You can check the [CHANGELOG](./CHANGELOG.md) for more information on the differ
5252
- Supports Vim navigation keys
5353

5454
**Note:** support of Chinese depends
55-
on [this additional plugin](https://github.com/aidenlx/cm-chs-patch). Please read its documentation for more
55+
on [this additional plugin](https://github.com/aidenlx/cm-chs-patch) (also you may need to clear search cache data to apply new Chinese index). Please read its documentation for more
5656
information.
5757

5858
## Projects that use Omnisearch

manifest-beta.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"id": "omnisearch",
33
"name": "Omnisearch",
4-
"version": "1.24.0-beta.1",
4+
"version": "1.24.0-beta.2",
55
"minAppVersion": "1.3.0",
66
"description": "A search engine that just works",
77
"author": "Simon Cambier",

src/cache-manager.ts

+12-3
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@ export class CacheManager {
108108
let content: string | null = null
109109

110110
const extractor = this.plugin.getTextExtractor()
111+
const aiImageAnalyzer = this.plugin.getAIImageAnalyzer()
111112

112113
// ** Plain text **
113114
// Just read the file content
@@ -161,10 +162,18 @@ export class CacheManager {
161162
// ** Image **
162163
else if (
163164
isFileImage(path) &&
164-
this.plugin.settings.imagesIndexing &&
165-
extractor?.canFileBeExtracted(path)
165+
((this.plugin.settings.imagesIndexing &&
166+
extractor?.canFileBeExtracted(path)) ||
167+
(this.plugin.settings.aiImageIndexing &&
168+
aiImageAnalyzer?.canBeAnalyzed(file)))
166169
) {
167-
content = await extractor.extractText(file)
170+
if (this.plugin.settings.imagesIndexing && extractor?.canFileBeExtracted(path)){
171+
content = await extractor.extractText(file)
172+
}
173+
174+
if (this.plugin.settings.aiImageIndexing && aiImageAnalyzer?.canBeAnalyzed(file)) {
175+
content = await aiImageAnalyzer.analyzeImage(file) + (content ?? '')
176+
}
168177
}
169178
// ** PDF **
170179
else if (

src/globals.ts

+5
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,11 @@ export type TextExtractorApi = {
9898
canFileBeExtracted: (filePath: string) => boolean
9999
}
100100

101+
export type AIImageAnalyzerAPI = {
102+
analyzeImage: (file: TFile) => Promise<string>;
103+
canBeAnalyzed: (file: TFile) => boolean;
104+
}
105+
101106
export const SEPARATORS =
102107
/[|\t\n\r\^"= -#%-*,.`\/<>:;?@[-\]_{}\u00A0\u00A1\u00A7\u00AB\u00B6\u00B7\u00BB\u00BF\u037E\u0387\u055A-\u055F\u0589\u058A\u05BE\u05C0\u05C3\u05C6\u05F3\u05F4\u0609\u060A\u060C\u060D\u061B\u061E\u061F\u066A-\u066D\u06D4\u0700-\u070D\u07F7-\u07F9\u0830-\u083E\u085E\u0964\u0965\u0970\u09FD\u0A76\u0AF0\u0C77\u0C84\u0DF4\u0E4F\u0E5A\u0E5B\u0F04-\u0F12\u0F14\u0F3A-\u0F3D\u0F85\u0FD0-\u0FD4\u0FD9\u0FDA\u104A-\u104F\u10FB\u1360-\u1368\u1400\u166E\u1680\u169B\u169C\u16EB-\u16ED\u1735\u1736\u17D4-\u17D6\u17D8-\u17DA\u1800-\u180A\u1944\u1945\u1A1E\u1A1F\u1AA0-\u1AA6\u1AA8-\u1AAD\u1B5A-\u1B60\u1BFC-\u1BFF\u1C3B-\u1C3F\u1C7E\u1C7F\u1CC0-\u1CC7\u1CD3\u2000-\u200A\u2010-\u2029\u202F-\u2043\u2045-\u2051\u2053-\u205F\u207D\u207E\u208D\u208E\u2308-\u230B\u2329\u232A\u2768-\u2775\u27C5\u27C6\u27E6-\u27EF\u2983-\u2998\u29D8-\u29DB\u29FC\u29FD\u2CF9-\u2CFC\u2CFE\u2CFF\u2D70\u2E00-\u2E2E\u2E30-\u2E4F\u3000-\u3003\u3008-\u3011\u3014-\u301F\u3030\u303D\u30A0\u30FB\uA4FE\uA4FF\uA60D-\uA60F\uA673\uA67E\uA6F2-\uA6F7\uA874-\uA877\uA8CE\uA8CF\uA8F8-\uA8FA\uA8FC\uA92E\uA92F\uA95F\uA9C1-\uA9CD\uA9DE\uA9DF\uAA5C-\uAA5F\uAADE\uAADF\uAAF0\uAAF1\uABEB\uFD3E\uFD3F\uFE10-\uFE19\uFE30-\uFE52\uFE54-\uFE61\uFE63\uFE68\uFE6A\uFE6B\uFF01-\uFF03\uFF05-\uFF0A\uFF0C-\uFF0F\uFF1A\uFF1B\uFF1F\uFF20\uFF3B-\uFF3D\uFF3F\uFF5B\uFF5D\uFF5F-\uFF65]/
103108
.toString()

src/main.ts

+9
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import {
1919
indexingStep,
2020
IndexingStepType,
2121
type TextExtractorApi,
22+
type AIImageAnalyzerAPI,
2223
} from './globals'
2324
import { notifyOnIndexed, registerAPI } from './tools/api'
2425
import { Database } from './database'
@@ -208,6 +209,14 @@ export default class OmnisearchPlugin extends Plugin {
208209
return (this.app as any).plugins?.plugins?.['text-extractor']?.api
209210
}
210211

212+
/**
213+
* Plugin dependency - Ai Image Analyzer
214+
* @returns
215+
*/
216+
public getAIImageAnalyzer(): AIImageAnalyzerAPI | undefined {
217+
return (this.app as any).plugins?.plugins?.['ai-image-analyzer']?.api
218+
}
219+
211220
private async populateIndex(): Promise<void> {
212221
console.time('Omnisearch - Indexing total time')
213222
indexingStep.set(IndexingStepType.ReadingFiles)

src/notes-indexer.ts

+4-1
Original file line numberDiff line numberDiff line change
@@ -44,14 +44,17 @@ export class NotesIndexer {
4444
public isContentIndexable(path: string): boolean {
4545
const settings = this.plugin.settings
4646
const hasTextExtractor = !!this.plugin.getTextExtractor()
47+
const hasAIImageAnalyzer = !!this.plugin.getAIImageAnalyzer()
4748
const canIndexPDF = hasTextExtractor && settings.PDFIndexing
4849
const canIndexImages = hasTextExtractor && settings.imagesIndexing
50+
const canIndexImagesAI = hasAIImageAnalyzer && settings.aiImageIndexing
4951
return (
5052
this.isFilePlaintext(path) ||
5153
isFileCanvas(path) ||
5254
isFileFromDataloom(path) ||
5355
(canIndexPDF && isFilePDF(path)) ||
54-
(canIndexImages && isFileImage(path))
56+
(canIndexImages && isFileImage(path)) ||
57+
(canIndexImagesAI && isFileImage(path))
5558
)
5659
}
5760

src/settings.ts

+39
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ export interface OmnisearchSettings extends WeightingSettings {
4545
imagesIndexing: boolean
4646
/** Enable Office documents indexing */
4747
officeIndexing: boolean
48+
/** Enable image ai indexing */
49+
aiImageIndexing: boolean
4850

4951
/** Enable indexing of unknown files */
5052
unsupportedFilesIndexing: 'yes' | 'no' | 'default'
@@ -106,6 +108,7 @@ export class SettingsTab extends PluginSettingTab {
106108
await database.clearCache()
107109
}, 1000)
108110

111+
const aiImageAnalyzer = this.plugin.getAIImageAnalyzer()
109112
containerEl.empty()
110113

111114
if (this.app.loadLocalStorage(K_DISABLE_OMNISEARCH) == '1') {
@@ -125,6 +128,24 @@ export class SettingsTab extends PluginSettingTab {
125128

126129
//#region Indexing
127130

131+
const indexingDesc = new DocumentFragment()
132+
indexingDesc.createSpan({}, span => {
133+
span.innerHTML = `⚠️ <span style="color: var(--text-accent)">Changing indexing settings will clear the cache, and requires a restart of Obsidian.</span><br/><br/>`
134+
if (textExtractor) {
135+
span.innerHTML += `
136+
👍 You have installed <a href="https://github.com/scambier/obsidian-text-extractor">Text Extractor</a>, Omnisearch can use it to index PDFs and images contents.
137+
<br />Text extraction only works on desktop, but the cache can be synchronized with your mobile device.`
138+
} else {
139+
span.innerHTML += `⚠️ Omnisearch requires <a href="https://github.com/scambier/obsidian-text-extractor">Text Extractor</a> to index PDFs and images.`
140+
}
141+
142+
if (aiImageAnalyzer) {
143+
span.innerHTML += `<br/>👍 You have installed <a href="https://github.com/Swaggeroo/obsidian-ai-image-analyzer">AI Image Analyzer</a>, Omnisearch can use it to index images contents with ai.`
144+
}else {
145+
span.innerHTML += `<br/>⚠️ Omnisearch requires <a href="https://github.com/Swaggeroo/obsidian-ai-image-analyzer">AI Image Analyzer</a> to index images with ai.`
146+
}
147+
})
148+
128149
new Setting(containerEl)
129150
.setName('Indexing')
130151
.setHeading()
@@ -191,6 +212,23 @@ export class SettingsTab extends PluginSettingTab {
191212
)
192213
.setDisabled(!textExtractor)
193214

215+
// AI Images Indexing
216+
const aiIndexImagesDesc = new DocumentFragment()
217+
aiIndexImagesDesc.createSpan({}, span => {
218+
span.innerHTML = `Omnisearch will use AI Image Analyzer to index the content of your images with ai.`
219+
})
220+
new Setting(containerEl)
221+
.setName(`Images AI indexing ${aiImageAnalyzer ? '' : '⚠️ Disabled'}`)
222+
.setDesc(aiIndexImagesDesc)
223+
.addToggle(toggle =>
224+
toggle.setValue(settings.aiImageIndexing).onChange(async v => {
225+
await database.clearCache()
226+
settings.aiImageIndexing = v
227+
await saveSettings(this.plugin)
228+
})
229+
)
230+
.setDisabled(!aiImageAnalyzer)
231+
194232
// Index filenames of unsupported files
195233
new Setting(containerEl)
196234
.setName('Index paths of unsupported files')
@@ -758,6 +796,7 @@ export function getDefaultSettings(app: App): OmnisearchSettings {
758796
PDFIndexing: false,
759797
officeIndexing: false,
760798
imagesIndexing: false,
799+
aiImageIndexing: false,
761800
unsupportedFilesIndexing: 'default',
762801
splitCamelCase: false,
763802
openInNewPane: false,

versions.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -143,5 +143,6 @@
143143
"1.23.0-beta.5": "1.3.0",
144144
"1.23.0": "1.3.0",
145145
"1.24.0-beta.1": "1.3.0",
146-
"1.23.1": "1.3.0"
146+
"1.23.1": "1.3.0",
147+
"1.24.0-beta.2": "1.3.0"
147148
}

0 commit comments

Comments
 (0)