Skip to content

Collection processors removal, product list-widget fixes

Compare
Choose a tag to compare
@alfredsgenkins alfredsgenkins released this 24 Aug 12:11

What's inside

  • Collection processors removal
  • Patches to product list-widget

Feature break-down

Collection processors removal

In this release following files in (src/Model/Resolver/Products/SearchCriteria/CollectionProcessor) were removed:

  • FilterProcessor.php
  • FilterProcessor/CategoryFilter.php
  • FilterProcessor/ConditionsFilter.php
  • FilterProcessor/ConfigurableProductAttributeFilter.php
  • FilterProcessor/CustomerGroupFilter.php
  • FilterProcessor/ProductIdFilter.php

Why? Well, since migration to Elasticsearch they... were not used! This means we are back to M2 core filter processors.

Patches to product list-widget

Following issues were resolved: scandipwa/scandipwa#724, scandipwa/scandipwa#835

The implementation made as Collection processor was removed (along-side other processors) and replaced by a plugin, working on the argument value resolving level. This means plugging to Magento\Framework\GraphQl\Query\Resolver\Argument\AstConverter. The solution is not perfect in terms of performance, but unfortunately, implementing it otherwise might break the internal logic of product-widget condition composition. We will wait, to see if Magento team does something about it.