Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include additional query parameters in query log #186

Open
tolbertam opened this issue Feb 22, 2017 · 0 comments
Open

Include additional query parameters in query log #186

tolbertam opened this issue Feb 22, 2017 · 0 comments
Assignees
@tolbertam
Labels
TechEnhancement

Comments

@tolbertam
Copy link
Contributor

tolbertam commented Feb 22, 2017 •
edited
Loading

Since adding V3 and V4 support there are a few more query parameters that would be nice to have surfaced in query log:

  • serialConsistency
  • timestamp

These would be Option since they may not always be present, and would only show up in an ActivityLog query if present.

It would also be nice to surface pageSize and pagingState but would like to reserve that for #169.
@tolbertam tolbertam self-assigned this Feb 22, 2017
@tolbertam tolbertam mentioned this issue Feb 23, 2017
Merged
tolbertam added a commit that referenced this issue Feb 24, 2017
@tolbertam
[#186] Add Serial Consistency Level and Timestamp to Activity Log (#187)
cc6ec71 
* [#186] Add Serial Consistency Level and Timestamp to Activity Log

Updates recorded queries in the ActivityLog to include Serial
Consistency Level and Timestamp if present in queries.  If the values
are not present, all the client implementations return null to indicate
that they weren't set.

Also fixes some bugs in the codec module:

- Use of Notations.consistency in favor of Consistency.codec caused
  NullPointerExceptions due to order of loading.  Use Consistency.codec
  instead in both Query and Batch.
- Bitmasking in BatchFlags was offset incorrectly.

* Fix version (1.1.2 was never released, so reuse)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tolbertam tolbertam

Labels
TechEnhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tolbertam