Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ds002680 animal/non-animal #18

Open
arnodelorme opened this issue May 2, 2023 · 0 comments
Open

ds002680 animal/non-animal #18

arnodelorme opened this issue May 2, 2023 · 0 comments

Comments

@arnodelorme
Copy link
Collaborator

arnodelorme commented May 2, 2023

To do

  • Fix channel location: Only place channel location in .set file, do not add electrode file
  • Fix channel location: Coordinates are wrong (too shrinked). fix
  • Events.json at the root not seen
  • Dung to clean
  • Kay says events in .set not consistent enough with events.tsv files (I have checked and they are)
  • Dataset description, add more information

Kay

Beyond what we discussed, there were a large number of errors in the json and events.tsv files themselves. For example the "stim_file" column in the events.tsv was called "stim_type" in the json. Similarly the "value" column in the events.tsv was called "type" in the json. The trial_type values listed in the json file did not correspond to the values in the trial_type column values in the events.tsv file. This is why we want people to generate the json template from the event files. etc. etc. There was also an annotation in the JSON for a "correct" column which doesn't exist in the event files. None of the annotations included an event type tag.

I have attached a finished JSON file which would go on the top level of your dataset directory. There is one thing that I didn't understand. The correct response was tagged with a key Release, whereas the incorrect response was tagged with a Hold-down. There was no explanation in the description. These two annotations will probably have to be modified.

I also included a summary of what appeared in your events. You have a total of 52662 events in 350 event files.

column_values_2023_05_01_T_14_52_08_573.txt

{
  "value": {
    "Description": "Value of event",
    "HED": {
      "difficult_target": "Sensory-event, Visual-presentation, Experimental-stimulus, Target, Complex, (Photograph, Animal)",
      "nonanimal_target": "Sensory-event, Visual-presentation, Experimental-stimulus, Target, (Photograph, (Not-equal-to, Animal))",
      "easy_distractor": "Sensory-event, Visual-presentation, Experimental-stimulus, Distractor, Simple, (Photograph, (Not-equal-to, Animal))",
      "correct": "Agent-action, Participant-response, Correct-action, (Finger, Release)",
      "incorrect": "Agent-action, Participant-response, Incorrect-action, (Finger, Hold-down)",
      "easy_target": "Sensory-event, Visual-presentation, Experimental-stimulus, Target, Simple, (Photograph, Animal)",
      "animal_distractor": "Sensory-event, Visual-presentation, Experimental-stimulus, Distractor, (Photograph, (Not-equal-to, Animal))",
      "difficult_distractor": "Sensory-event, Visual-presentation, Experimental-stimulus, Distractor, Complex, (Photograph, (Not-equal-to, Animal))",
      "animal_target": "Sensory-event, Visual-presentation, Experimental-stimulus, Target, (Photograph, Animal)",
      "nonanimal_distractor": "Sensory-event, Visual-presentation, Experimental-stimulus, Distractor, (Photograph, (Not-equal-to, Animal))"
    },  
    "Levels": {
      "animal_target": "An image containing an animal that is a target in a go-nogo animal categorization task",
      "easy_target": "An image containing an animal (easy to detect) that is a target in a single target image detection task",
      "difficult_target": "An image containing an animal (hard to detect) that is a target in a single target image detection task",
      "nonanimal_target": "An image not containing an animal that is a target in a single target image detection task",
      "animal_distractor": "An image not containing an animal that is a distractor in a go-nogo animal categorization task",
      "easy_distractor": "An image not containing an animal that is a distractor in a single target easy animal image detection task",
      "difficult_distractor": "An image not containing an animal that is a distractor in a single target difficult animal image detection task",
      "nonanimal_distractor": "An image not containing an animal that is a distractor in a single target non-animal image detection task",
      "correct": "Correct response",
      "incorrect": "Incorrect response"
    }
  },
  "stim_file": {
    "Description": "Stimulus image presented",
    "HED" : "Pathname/#"
  },
  "response_time": {
    "Description": "Reaction time",
    "Units": "millisecond"
  }
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants