Favicon changed? now showing up white on white

[luckman212]

Not sure if this started in 1.10.3 but my favicon is now almost invisible :(

normal

hover

[luckman212]

Not sure if it's related to this error in my console

found this: iamshaunjp/pwa-tutorial#1

[luckman212]

Yes the browser detection is neat but seems overly complex and a bit fiddly. I don't mind the high contrast icon at all. I suppose if it really bothers people it could be made into some kind of configurable environment variable?

-e FAVICON_URL="./whatever.ico"

[luckman212]

Updated to 1.10.5 ... LGTM 🚀

Light

Dark

[schlagmichdoch]

The following comments were deleted by GitHub (via hubot) as part of mistakenly marking this account as spam on 17th February 2024. The correct thread order and the creation date is unclear. I decided to manually restore them anyway in order to complete the information this issue holds even though the restored information might be outdated:

Comment by @schlagmichdoch:

Not related to the error.

I've changed all icons to be consistent on all platforms:
https://github.com/schlagmichdoch/PairDrop/blob/master/public/images/android-chrome-512x512.png

I really like the clean look of the simple white favicon as GitHub does it:
Firefox dark mode:
![image](https://github.com/schlagmichdoch/PairDrop/assets/52242352/cba43814-976e-41bb-996f-b3d7e5381848

Apparently, I have missed though, that some people are still using light mode on some browsers with light navbars 🙈

Sorry for the inconvenience!

We have two possibilities now:

1. Two favicons: One for light mode, one for dark mode
2. One favicon that has high contrast on all backgrounds

Two favicons

This is done by GitHub: Normally the favicon is black. The page then detects whether the browser prefers dark mode and uses a white favicon instead. You can check this by opening github.com and changing the browser settings.
This seems to work on Firefox (and probably Safari) but does not show the correct icon on Chromium and also if the header bar is always dark.

Firefox dark mode:

Firefox light mode:

One favicon with high contrast

I'd prefer this. I would then use the white icon on blue background that is already used for everything else:
Chromium light mode:

Chromium dark mode:

What do you think?

Comment by @schlagmichdoch:

I‘d like to be consistent between self hosted versions and pairdrop.net.

So I will change the icon to the blue icon for the next version v1.10.4 in the next days. Thanks for your input!