Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Union Types - code/tests improvements #1576

Open
scyzoryck opened this issue Dec 3, 2024 · 0 comments
Open

Union Types - code/tests improvements #1576

scyzoryck opened this issue Dec 3, 2024 · 0 comments
Labels
Union Types Support for Union Types

Comments

@scyzoryck
Copy link
Collaborator

scyzoryck commented Dec 3, 2024 •
edited
Loading

Q A
Bug report? no
Feature request? no
BC Break report? no
RFC? yes

Ideas:

  • the more I look at this the more I think that it would make sense to use the order used in the code (by looking at how the union types are declared) rather that having our own way of sorting. From fix detection of primitive types on union type #1575
  • add dataProviders into tests
  • move tests into Abstract Serialization test case - now they are mainly in JSON only.
  • Create UnionTypesDriver

Expected Result

  • Better tests and coverage for Unions. Easier maintenance for Unions.

Actual Result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Union Types Support for Union Types
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@scyzoryck