Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional check to prevent false positive endpoints #93

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add additional check to prevent false positive endpoints #93

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e91611
Add additional check to prevent false positive endpoints
hanslovsky Mar 2, 2023
e0269fb
Revert "Add additional check to prevent false positive endpoints"
hanslovsky Mar 2, 2023
a5b4226
Exclude grpc:// from potential endpoint strings
hanslovsky Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/jgo/jgo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ def run_and_combine_outputs(command, *args):

def find_endpoint(argv, shortcuts={}):
# endpoint is first positional argument
pattern = re.compile("(.*https?://.*|[a-zA-Z]:\\.*)")
pattern = re.compile("(.*(https?|grpc)://.*|[a-zA-Z]:\\.*)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this just kicks the can down the road. Another protocol will hit this problem, and be needed to be added to the regex.

For the case mentioned in #92 , the problem is that the -- isnt being treat with sufficient priority. Everything after the -- should be ignored.

indices = []
for index, arg in enumerate(argv):
if arg in shortcuts or (Endpoint.is_endpoint(arg) and not pattern.match(arg)):
Expand Down